Remove language_version from .pre-commit-hooks.yaml
#258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables `default_language_version` stanzas in consuming `.pre-commit-config.yaml` files to take precedence.
|
@adamchainz appreciate your work maintaining this project. Wanted to tag you to ask if you had some time to consider this PR. |
adamchainz
approved these changes
Aug 16, 2023
adamchainz
pushed a commit
to maxb2/blacken-docs
that referenced
this pull request
Aug 16, 2023
This enables `default_language_version` stanzas in consuming `.pre-commit-config.yaml` files to take precedence. This change is the same as psf/black#2430, see that PR for full context on why this is beneficial. This was previously PR'ed to this project as adamchainz#144. It was closed at the time so my company has been keeping a fork of this project with the patch applied. With the new maintainership, I wanted to ask whether this change would be accepted at this time. Thanks in advance for taking a look, happy to answer any questions.
paddyroddy
referenced
this pull request
in paddyroddy/python-template
Aug 16, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [adamchainz/blacken-docs](https://togithub.com/adamchainz/blacken-docs) | repository | minor | `1.15.0` -> `1.16.0` | Note: The `pre-commit` manager in Renovate is not supported by the `pre-commit` maintainers or community. Please do not report any problems there, instead [create a Discussion in the Renovate repository](https://togithub.com/renovatebot/renovate/discussions/new) if you have any questions. --- ### Release Notes <details> <summary>adamchainz/blacken-docs (adamchainz/blacken-docs)</summary> ### [`v1.16.0`](https://togithub.com/adamchainz/blacken-docs/blob/HEAD/CHANGELOG.rst#1160-2023-08-16) [Compare Source](https://togithub.com/adamchainz/blacken-docs/compare/1.15.0...1.16.0) - Allow Markdown fence options. Thanks to initial work from Matthew Anderson in `PR #​246 <https://github.com/adamchainz/blacken-docs/pull/246>`\__. - Expand Markdown detection to all Python language names from Pygments: `py`, `sage`, `python3`, `py3`, and `numpy`. - Preserve leading whitespace lines in reStructuredText code blocks. Thanks to Julianus Pfeuffer for the report in `Issue #​217 <https://github.com/adamchainz/blacken-docs/issues/217>`\__. - Use exit code 2 to indicate errors from Black, whilst exit code 1 remains for “files have been formatted”. Thanks to Julianus Pfeuffer for the report in `Issue #​218 <https://github.com/adamchainz/blacken-docs/issues/218>`\__. - Support passing the `--preview` option through to Black, to select the future style. - Remove `language_version` from `.pre-commit-hooks.yaml`. This change allows `default_language_version` in \`\`.pre-commit-config.yaml\` to take precedence. Thanks to Aneesh Agrawal in `PR #​258 <https://github.com/adamchainz/blacken-docs/pull/258>`\__. </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/paddyroddy/python-template). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi40My4yIiwidXBkYXRlZEluVmVyIjoiMzYuNDMuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
|
Thanks for taking a look and cutting a release! Upgrading to the new version in all repos at my company :) |
paddyroddy
referenced
this pull request
in astro-informatics/sleplet
Aug 29, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [adamchainz/blacken-docs](https://togithub.com/adamchainz/blacken-docs) | repository | minor | `1.15.0` -> `1.16.0` | Note: The `pre-commit` manager in Renovate is not supported by the `pre-commit` maintainers or community. Please do not report any problems there, instead [create a Discussion in the Renovate repository](https://togithub.com/renovatebot/renovate/discussions/new) if you have any questions. --- ### Release Notes <details> <summary>adamchainz/blacken-docs (adamchainz/blacken-docs)</summary> ### [`v1.16.0`](https://togithub.com/adamchainz/blacken-docs/blob/HEAD/CHANGELOG.rst#1160-2023-08-16) [Compare Source](https://togithub.com/adamchainz/blacken-docs/compare/1.15.0...1.16.0) - Allow Markdown fence options. Thanks to initial work from Matthew Anderson in `PR #​246 <https://github.com/adamchainz/blacken-docs/pull/246>`\__. - Expand Markdown detection to all Python language names from Pygments: `py`, `sage`, `python3`, `py3`, and `numpy`. - Preserve leading whitespace lines in reStructuredText code blocks. Thanks to Julianus Pfeuffer for the report in `Issue #​217 <https://github.com/adamchainz/blacken-docs/issues/217>`\__. - Use exit code 2 to indicate errors from Black, whilst exit code 1 remains for “files have been formatted”. Thanks to Julianus Pfeuffer for the report in `Issue #​218 <https://github.com/adamchainz/blacken-docs/issues/218>`\__. - Support passing the `--preview` option through to Black, to select the future style. - Remove `language_version` from `.pre-commit-hooks.yaml`. This change allows `default_language_version` in \`\`.pre-commit-config.yaml\` to take precedence. Thanks to Aneesh Agrawal in `PR #​258 <https://github.com/adamchainz/blacken-docs/pull/258>`\__. </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/astro-informatics/sleplet). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi40My4yIiwidXBkYXRlZEluVmVyIjoiMzYuNDMuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables
default_language_versionstanzasin consuming
.pre-commit-config.yamlfiles to take precedence.This change is the same as psf/black#2430,
see that PR for full context on why this is beneficial.
This was previously PR'ed to this project as #144.
It was closed at the time so my company has been keeping a fork of this project with the patch applied.
With the new maintainership, I wanted to ask whether this change would be accepted at this time.
Thanks in advance for taking a look, happy to answer any questions.