-
-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix example app current_url_abs_path demo #370
Conversation
.idea/.gitignore
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't add your IDE-specific files to open source projects. Put them in your global Git ignore file so that you never accidentally add them: https://adamj.eu/tech/2022/11/06/git-set-up-a-global-ignore-file/
@@ -36,7 +36,7 @@ | |||
</tr> | |||
<tr> | |||
<td><code>request.htmx.current_url_relative</code></td> | |||
<td><code>{{ request.htmx.current_url_relative|stringformat:'r' }}</code></td> | |||
<td><code>{{ request.htmx.current_url_abs_path|stringformat:'r' }}</code></td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks this was indeed a mistake in the original PR #287
@@ -35,8 +35,8 @@ | |||
<td><code>{{ request.htmx.current_url|stringformat:'r' }}</code></td> | |||
</tr> | |||
<tr> | |||
<td><code>request.htmx.current_url_relative</code></td> | |||
<td><code>{{ request.htmx.current_url_relative|stringformat:'r' }}</code></td> | |||
<td><code>request.htmx.current_url_abs_path</code></td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops you missed this line 😉
Fixes #368
try to review the change I made,
I welcome any criticism to it.