Fix example app current_url_abs_path demo #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamchainz
approved these changes
Sep 19, 2023
.idea/.gitignore
Outdated
There was a problem hiding this comment.
Please don't add your IDE-specific files to open source projects. Put them in your global Git ignore file so that you never accidentally add them: https://adamj.eu/tech/2022/11/06/git-set-up-a-global-ignore-file/
| @@ -36,7 +36,7 @@ | |||
| </tr> | |||
| <tr> | |||
| <td><code>request.htmx.current_url_relative</code></td> | |||
| <td><code>{{ request.htmx.current_url_relative|stringformat:'r' }}</code></td> | |||
| <td><code>{{ request.htmx.current_url_abs_path|stringformat:'r' }}</code></td> | |||
There was a problem hiding this comment.
thanks this was indeed a mistake in the original PR #287
adamchainz
changed the title
adamchainz
reviewed
Sep 19, 2023
| @@ -35,8 +35,8 @@ | |||
| <td><code>{{ request.htmx.current_url|stringformat:'r' }}</code></td> | |||
| </tr> | |||
| <tr> | |||
| <td><code>request.htmx.current_url_relative</code></td> | |||
| <td><code>{{ request.htmx.current_url_relative|stringformat:'r' }}</code></td> | |||
| <td><code>request.htmx.current_url_abs_path</code></td> | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #368
try to review the change I made,
I welcome any criticism to it.