Add redirect_middleware for handling htmx request redirects #406
Conversation
This commit adds a new function, `redirect_middleware`, to handle redirects for htmx requests for login required views. The middleware function checks if the request is an htmx request and if the response status code is 302 (redirection). If so, it parses the redirection location. If the redirection location is the login URL, it changes the redirection URL to point to the login redirect URL and changes the response status code to 204 (No Content). The modified response is then returned. The `redirect_middleware` function is added to the `django_htmx/middleware.py` file.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…middleware()" This reverts commit 6e1cb9f.
There was a problem hiding this comment.
I don’t think this is a good way of handling things. It would be better to have an htmx-ready version of @login_required that returns an htmx redirect response.
But also I am entirely convinced that there should be a feature in django-htmx at all. What to do regarding login is somewhat project-dependent. A section in the “Tips” documentation page might be a better approach.
|
|
||
| .. code-block:: python | ||
|
|
||
| def redirect_middleware(get_response): |
There was a problem hiding this comment.
copy-pasting the source code into the docs isn't necessary. they would drift over time.
There was a problem hiding this comment.
I think you're right, it does seem to be project-specific what should be done in cases like these. Thanks for taking the time to review!
| def middleware(request): | ||
| response = get_response(request) | ||
| if request.headers.get("HX-Request") and response.status_code == 302: | ||
| location = urlparse(response["Location"]) |
There was a problem hiding this comment.
fyi urlsplit is preferable https://www.youtube.com/watch?v=ABJvdsIANds
| response = get_response(request) | ||
| if request.headers.get("HX-Request") and response.status_code == 302: | ||
| location = urlparse(response["Location"]) | ||
| if location.path == settings.LOGIN_URL: |
There was a problem hiding this comment.
@login_required might use a different login_url, so this is fragile. Wrapping login_required would solve this
| redirect_url = ( | ||
| f"{settings.LOGIN_URL}?next={settings.LOGIN_REDIRECT_URL}" | ||
| ) |
This commit adds a new function,
redirect_middleware, to handle redirects for htmx requests for login required views.This should address issues where htmx performs a request against a view decorated with
@login_required.The middleware function checks if the request is an htmx request and if the response status code is 302 (redirection). If so, it parses the redirection location. If the redirection location is the login URL, it changes the redirection URL to point to the login redirect URL and changes the response status code to 204 (No Content). The modified response is then returned.
The
redirect_middlewarefunction is added to thedjango_htmx/middleware.pyfile.