-
-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add django-template-partials example to Tips #413
Conversation
This project uses present tense PR titles/commit messages without a full-stop at the end, because that makes grammatical sense for a headline 😉 |
I like the start here, but I think we should have two sections. One to cover the “render a small portion of the page” style that django-template-partials is perfect for, and another for the “render the only main section” style that the current tip covers. I wrote the current tip after several people asked for it, but I think the django-template-partials style is more in-keeping with the htmx philosophy. WDYT? |
Hey @adamchainz — It's your package, so happy to follow your lead. 😀 From what you wrote I can't quite work out if you mean:
FWIW I'm using dtp for both IRL, but I'd rather add the example(s) you'd be happiest with here. LMK and I'll update. 🎁 |
Coming back to django-htmx after a bit of a break. I think perhaps let’s change to showcase only django-template-partials, especially since you’ll now be getting something similar into Django itself. Let’s make these changes:
What do you think? |
Hey @adamchainz. Makes sense. Give me a little cycle and I'll get that done. 👍 |
@adamchainz I've made the changes in the example project. I updated the existing view. Do you think it's worth duplicating what's there to have both methods runnable? Will move to docs next. |
Hey @adamchainz. Summer 🏖️ I've made what I hope is an OK pass at the suggested changes. If you could glance at them when you can, I can make any adjustments you want, and then squash down etc. (Do just edit, if that's easier for you too!) Thanks. |
Okay, finally, there we go! Thank you 💚 |
Slowly slowly catchy monkey 🐵 Thanks Adam. |
Hey @adamchainz 👋
I saw on the Fedi that you might accept an example using django-template-partials to the tips section, so I drafted one.