Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unrelated comment was deleted after a change #495

Closed
BonaFideIT opened this issue Oct 10, 2024 · 0 comments
Closed

Unrelated comment was deleted after a change #495

BonaFideIT opened this issue Oct 10, 2024 · 0 comments

Comments

@BonaFideIT
Copy link
Contributor

Python Version

3.11.10

Django Version

4.2.15

Package Version

1.21.0

Description

Hi,

while upgrading the devel branch from https://github.com/django-guardian/django-guardian to a new django version, we run django-upgrade like this git ls-files -z -- '*.py' | xargs -0 django-upgrade --target-version 5.0.

The following code of https://github.com/django-guardian/django-guardian/blob/devel/guardian/__init__.py:

from . import checks
import django

if django.VERSION < (3, 2):
    default_app_config = 'guardian.apps.GuardianConfig'

# PEP 396: The __version__ attribute's value SHOULD be a string.
__version__ = '2.4.0'

...

changed to:

from . import checks
import django

__version__ = '2.4.0'

...

We think the comment # PEP 396: The __version__ attribute's value SHOULD be a string. should not be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant