Skip to content

Commit

Permalink
vdev_id: Create symlinks even if no /dev/mapper/
Browse files Browse the repository at this point in the history
vdev_id uses the /dev/mapper/ symlinks to resolve a UUID to a dm name
(like dm-1).  However on some multipath setups, there is no /dev/mapper/
entry for the UUID at the time vdev_id is called by udev.  However,
this isn't necessarily needed, as we may be able to resolve the dm
name from the $DEVNAME that udev passes us (like DEVNAME="/dev/dm-1").

This patch tries to resolve the dm name from $DEVNAME first, before
falling back to looking in /dev/mapper/.  This fixed an issue where the
by-vdev names weren't reliably showing up on one of our nodes.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes openzfs#11698
  • Loading branch information
tonyhutter authored and adamdmoss committed Apr 10, 2021
1 parent 20d4d48 commit 1a40fcb
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion cmd/vdev_id/vdev_id
Original file line number Diff line number Diff line change
Expand Up @@ -298,8 +298,15 @@ sas_handler() {

# Utilize DM device name to gather subordinate block devices
# using sysfs to avoid userspace utilities
DMDEV=$(ls -l --full-time /dev/mapper | grep $DM_NAME |

# If our DEVNAME is something like /dev/dm-177, then we may be
# able to get our DMDEV from it.
DMDEV=$(echo $DEVNAME | sed 's;/dev/;;g')
if [ ! -e /sys/block/$DMDEV/slaves/* ] ; then
# It's not there, try looking in /dev/mapper
DMDEV=$(ls -l --full-time /dev/mapper | grep $DM_NAME |
awk '{gsub("../", " "); print $NF}')
fi

# Use sysfs pointers in /sys/block/dm-X/slaves because using
# userspace tools creates lots of overhead and should be avoided
Expand Down

0 comments on commit 1a40fcb

Please sign in to comment.