Fix for Mocha 6 #291
Closed
Fix for Mocha 6 #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mocha 6 introduced a new "stats-collector" that reporters have to manually instantiate in order to get stats. If running under Mocha 6 reporters that haven't done this will throw exceptions like `Cannot read property 'passes' of undefined` or `Cannot read property 'failures' of undefined`. fixes adamgruber#269 fixes adamgruber#282
adamgruber
requested changes
Aug 29, 2019
| // initialize the stats collector. Attempt to remedy that here. | ||
| if (!runner.stats) { | ||
| const createStatsCollector = require('mocha/lib/stats-collector'); | ||
| if (typeof createStatsCollector === 'function') { |
|
Hi guys, |
|
Did test it, works great |
|
@jasonk Are you able to finish working on this? |
|
Did some testing on this. It does allow mochawesome to work with cypress and mocha 6 but it does not work if you are using an earlier version of mocha. Also breaks when just using mocha 5 directly. |
adamgruber
reviewed
Oct 21, 2019
| @@ -81,6 +81,16 @@ function Mochawesome(runner, options) { | |||
| // Set the config options | |||
| this.config = conf(options); | |||
|
|
|||
| // If the runner doesn't have a stats object then we're probably | |||
| // running under Mocha 6 but were started in a way that didn't | |||
There was a problem hiding this comment.
I don't think this assumption is true. When running under Mocha 5, runner.stats will be undefined at this point and trying to require stats-collector will throw because it doesn't exist. When running directly in Mocha 6, runner.stats will be an object at this point.
|
This change has been added in #303. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mocha 6 introduced a new "stats-collector" that has to be instantiated
in order to get stats. If you are using Mocha itself directly this
works fine, but a lot of things that are running Mocha
programatically, or overriding
Mocha.prototype.runstill haven't gotthis right yet (Cypress is the big one for me).
Ideally this would be the frameworks problem to fix, but since it's
relatively simple to make Mochawesome work regardless of whether the
runner initialized correctly, I thought you might be interested.
fixes #269
fixes #282