Skip to content
This repository was archived by the owner on Dec 7, 2021. It is now read-only.

Conversation

alexgb
Copy link
Contributor

@alexgb alexgb commented Jul 20, 2017

If a user returns to the app before the oauth login flow completes, a hanging deep link event handler will cause the next oauth flow to trigger two token requests. In the case of google oauth, this will result in an invalid_grant error.

Steps to reproduce:

  1. Configure an app to oauth using google
  2. On iOS, trigger an oauth flow and return to the app using the "back-to" button in the status bar
  3. Trigger oauth again and this time complete the flow and click the open button in the dialog to deep link back to your app
  4. You should now see an invalid_grant error

This PR fixes this case by ensuring that only a single active deep linking url handler can exist at a time.

@adamjmcgrath
Copy link
Owner

adamjmcgrath commented Jul 29, 2017

Hi, sorry am away at the moment so not been able to look at this. Back late next week so will take a look then.

@adamjmcgrath adamjmcgrath reopened this Jul 29, 2017
@adamjmcgrath adamjmcgrath merged commit e149b14 into adamjmcgrath:master Dec 16, 2017
@adamjmcgrath
Copy link
Owner

lgtm, apologies for the wait...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants