could you make scrollbar on the right hidden as it's a bit distracting when watching videos and a video web page is not that long to need it. [youtube classic] #106

mhwgoo · 2024-10-25T17:17:27Z

My browser has this feature, but this script overrides it, thanks!

adamlui · 2024-10-26T00:52:33Z

Can you disable the script, then screenshot what you mean?

mhwgoo · 2024-10-26T03:14:10Z

Sorry I may have misjudged yesterday. It is my browser's little quirk, not your userscript. The scenario is that when the youtube webpage is refreshed, all prior configs and this youtube classic userscript got lost. Like this:

before refreshment:
after refreshment:

adamlui · 2024-10-27T06:23:19Z

Hey @mhwgoo when I refresh it stays square, what browser and userscript manager are you using?

Also do you think it should hide Shorts?

mhwgoo · 2024-10-27T12:27:46Z

I've been using qutebrowser recently, and I put your script under $HOME//.qutebrowser/greasemonkey folder as the official docs indicate.

I dont' know about others, but I never watch Shorts, and I'd like it to be hidden.

BTW, it'd be great if ad nodes could be deleted and not rendered (instead of hidden). I wrote a little something:

window.addEventListener('animationstart', function() {
    'use strict';

    var ads = document.getElementsByTagName("ytd-ad-slot-renderer");
    for (var i = 0; i < ads.length; i++) {
        ads[i].parentNode.parentNode.remove();
    }
});

It sometimes works, sometimes doesn't. I don't know why. Could you add this kind of feature? I'm not familiar with javascript and the workings of youtube. Thanks!

mhwgoo · 2024-10-28T07:10:06Z

It looks like it works when there is this css style:

ytd-ad-slot-renderer {
  display: none;
}

adamlui · 2024-10-28T07:11:24Z

Thanks for the info @mhwgoo I updated userscript so Shorts sections are now hidden

Re: qutebrowser refresh bug, I downloaded the Windows installer from https://github.com/qutebrowser/qutebrowser/releases but BitDefender alerted me to malware...

...so I'm not comfortable testing it unfortunately

It looks like it works when there is this css style:
ytd-ad-slot-renderer {
  display: none;
}

Do you wanna be a contributor by adding it to the CSS? (or I could do it for you if too lazy)

mhwgoo · 2024-10-28T07:19:32Z

ytd-ad-slot-renderer {
  display: none;
}

This only hides the node with a black block still there. But with this portion of css, the following javascript achieves my intention of making ads disappear:

window.addEventListener('animationstart', function() {
    'use strict';

    var ads = document.getElementsByTagName("ytd-ad-slot-renderer");
    for (var i = 0; i < ads.length; i++) {
        ads[i].parentNode.parentNode.remove();
    }
});

I'm not sure it's the right way from your expert opinion, afterall I never write javascript and css projects before. I mean, I think the above code is a bit weird, it trys to delete nodes, why does it need the support of the node being display: none;?

adamlui · 2024-10-28T07:28:00Z

Ok I understand now, for the removal the shortest command is:

document.querySelectorAll('ytd-ad-slot-renderer').forEach(ad => ad.parentNode.parentNode.remove())

... and are you saying, when you added the remover using event listener, sometimes it removed, sometimes it did not, but when you also add teh CSS, it always removed? (if so that is quite strange since CSS does not affect whether listener timing was correct so would still show the black boxes)

adamlui · 2024-10-28T07:29:39Z

NVM I understand what you're saying, "with this portion of css" you meant the selector in the remover, but still it doesn't always remove. Let me figure out the best way brb

mhwgoo · 2024-10-28T07:37:03Z

Yeah, you got what I meant. Together "with this portion of css", the above javascript makes the whole youtube web page appear about right (deleted the ad nodes and thus not displaying them). Maybe because the eventlistener's chosen trigger type is animationstart? I've tested other types including load, not even close. Super weird. Thanks for your help:)

…e-classic`]

adamlui · 2024-10-28T08:32:36Z

Ok I figured it out, it kept re-adding so a mutation observer is the best solution, can you update to the latest version 2024.10.28.3 and test it out in qutebrowser

adamlui · 2024-10-28T08:56:43Z

One thing I noticed, now when scrolling and lazy loading finishes, new ads are re-added but instantly removed, so the grid of videos compresses to fill in blank space and all the thumbnails move.

Before when hiding only, this phenomenon does not occur, but there are ugly gaps. Which way is worse? Also what do you think about an option to hide or remove so user picks their poison?

adamlui · 2024-10-28T09:12:15Z

Actually I just tested without the script, YouTube already jars the user by scrolling up instead of staying in place, so I think they will be used to this disorientation already and your ad removal idea is best

adamlui · 2024-10-28T09:16:55Z

Also check this out

Removal results in ugly gaps at ends of some rows for me

adamlui · 2024-10-28T09:20:11Z

NVM jsut fixed it also the grid no longer rearranges either

mhwgoo · 2024-10-28T09:54:08Z

After my last comment, I found youtube is so gross that it keeps refreshes itself with new ads. Just when I was figuring it out, your message came. Just in time. I will test it and think about your question after dinner. Thanks!

adamlui · 2024-10-28T12:13:21Z

Btw Google employees closely follow my git activity, and recently YouTube notoriously warns accounts for running ad blocker, also Chrome team just stirred great controversy by banning popular AdBlock extension, so out activity here might draw scrutiny towards this script (but they dont control my publishing so no fear of Chrome Store punishment, just they could add code to block this script in the future)

mhwgoo · 2024-10-28T16:23:42Z

Hi @adamlui, I tested the latest version, and it seemed that the page didn't appear as intended. It had this same appearance as soon as the page was first rendered, scrolled down and scrolled back up. Youtube's patterned ad spots were still there. (In fact I had thought about deleting nodes according to this pattern but given up this way as pattern could easily vary in the future)

mhwgoo · 2024-10-28T16:30:59Z

I did a little thought experiment after I found yt's refreshment activity with the probably non-idiomatic ugly repetitive js code below in a standalone userscript together with a global stylesheet.css, just to offer some immature ideas here. The page appeared a lot cleaner when first loaded, scrolled down and back up (with occasional transient display:none blocks though).

var ads = document.getElementsByTagName("ytd-ad-slot-renderer");

window.addEventListener('animationstart', function() {
    if (ads) {
        for (var i = 0; i < ads.length; i++ ) {
            ads[i].parentNode.parentNode.remove();
        }
    }
    ads = document.getElementsByTagName("ytd-ad-slot-renderer");
});

window.addEventListener('animationend', function() {
    if (ads) {
        for (var i = 0; i < ads.length; i++ ) {
            ads[i].parentNode.parentNode.remove();
        }
    }
    ads = document.getElementsByTagName("ytd-ad-slot-renderer");
});

window.addEventListener('load', function() {
    if (ads) {
        for (var i = 0; i < ads.length; i++ ) {
            ads[i].parentNode.parentNode.remove();
        }
    }
    ads = document.getElementsByTagName("ytd-ad-slot-renderer");
});

mhwgoo · 2024-10-28T16:42:47Z

In fact I had been using Brave browser for several years until a few days ago. Brave did some awesome special treatments with yt, making it look like there were no ad at all in all pages as well as within each video. Don't know how Brave achieves that. So I couldn't imagine yt has become like this. If it wanted to counter ad blocks, it'd better take on some big players like Brave Browser first.

adamlui · 2024-10-28T17:27:45Z

Actually Google triggered a ton of users to switch to Brave after the banning alert. But I will fix it to work in qutebrowser but tomorrow because I was up all night doing something so I have to sleep all day now

adamlui · 2024-10-28T17:29:52Z

Ironically Brave originally lured users using crypto as reward for their push ads (and it still spams you but the pay is pennies compared to the golden days)

mhwgoo · 2024-10-29T09:53:09Z

China right now.

mhwgoo · 2024-10-29T11:00:30Z

Seemed even worse now after adding async, await code

adamlui · 2024-10-30T03:55:17Z

ok can you reset by replacing script with the latest version, and then Ctrl+F for document-start and replace w/ document-end and does the observer error still occur

mhwgoo · 2024-10-30T05:51:25Z

Everything looked just perfect (no observer error, no blank boxes), until a new tab was opened and go to youtube.com.

Tab one:

Tab two:

…/userscripts#106)

… [auto-sync from `adamlui/youtube-classic`]

adamlui · 2024-10-30T07:37:25Z

ok can you install the latest version is there still observer error

adamlui · 2024-10-30T07:39:21Z

Tab two doesn't show the custom logo so script didn't load for some reason (custom logo is indicator of script looad now since i replaced .innerHTML which qutebrowser doesn't like) so the blank boxes are result from ad blocker you're using I think

mhwgoo · 2024-10-30T09:09:56Z

I got (with the custom logo shown):

YouTube™ Classic 📺 — (Remove rounded design + Return YouTube dislikes) called unimplemented GM_registerMenuCommand
userscript:GM-https://github.com/adamlui/YouTube%E2%84%A2 Classic %F0%9F%93%BA %E2%80%94 (Remove rounded design + Return YouTube dislikes):1692 Uncaught TypeError: Cannot read properties of null (reading 'appendChild')
    at userscript:GM-https://github.com/adamlui/YouTube%E2%84%A2 Classic %F0%9F%93%BA %E2%80%94 (/Remove rounded design + Return YouTube dislikes):1692:24
    at userscript:GM-https://github.com/adamlui/YouTube%E2%84%A2 Classic %F0%9F%93%BA %E2%80%94 (/Remove rounded design + Return YouTube dislikes):1693:7
    at userscript:GM-https://github.com/adamlui/YouTube%E2%84%A2 Classic %F0%9F%93%BA %E2%80%94 (/Remove rounded design + Return YouTube dislikes):2208:3
    at userscript:GM-https://github.com/adamlui/YouTube%E2%84%A2 Classic %F0%9F%93%BA %E2%80%94 (/Remove rounded design + Return YouTube dislikes):2213:3
(anonymous) @ userscript:GM-https://github.com/adamlui/YouTube%E2%84%A2 Classic %F0%9F%93%BA %E2%80%94 (Remove rounded design + Return YouTube dislikes):1692
(anonymous) @ userscript:GM-https://github.com/adamlui/YouTube%E2%84%A2 Classic %F0%9F%93%BA %E2%80%94 (Remove rounded design + Return YouTube dislikes):1693
(anonymous) @ userscript:GM-https://github.com/adamlui/YouTube%E2%84%A2 Classic %F0%9F%93%BA %E2%80%94 (Remove rounded design + Return YouTube dislikes):2208
(anonymous) @ userscript:GM-https://github.com/adamlui/YouTube%E2%84%A2 Classic %F0%9F%93%BA %E2%80%94 (Remove rounded design + Return YouTube dislikes):2213
userscript:GM-https://github.com/adamlui/YouTube%E2%84%A2 Classic %F0%9F%93%BA %E2%80%94 (Remove rounded design + Return YouTube dislikes):449 Uncaught (in promise) TypeError: Failed to execute 'observe' on 'MutationObserver': parameter 1 is not of type 'Node'.
    at userscript:GM-https://github.com/adamlui/YouTube%E2%84%A2 Classic %F0%9F%93%BA %E2%80%94 (/Remove rounded design + Return YouTube dislikes):449:16
    at new Promise (<anonymous>)
    at waitForElem (userscript:GM-https://github.com/adamlui/YouTube%E2%84%A2 Classic %F0%9F%93%BA %E2%80%94 (/Remove rounded design + Return YouTube dislikes):445:16)
    at userscript:GM-https://github.com/adamlui/YouTube%E2%84%A2 Classic %F0%9F%93%BA %E2%80%94 (/Remove rounded design + Return YouTube dislikes):477:5
    at userscript:GM-https://github.com/adamlui/YouTube%E2%84%A2 Classic %F0%9F%93%BA %E2%80%94 (/Remove rounded design + Return YouTube dislikes):2208:3
    at userscript:GM-https://github.com/adamlui/YouTube%E2%84%A2 Classic %F0%9F%93%BA %E2%80%94 (/Remove rounded design + Return YouTube dislikes):2213:3
(anonymous) @ userscript:GM-https://github.com/adamlui/YouTube%E2%84%A2 Classic %F0%9F%93%BA %E2%80%94 (Remove rounded design + Return YouTube dislikes):449
waitForElem @ userscript:GM-https://github.com/adamlui/YouTube%E2%84%A2 Classic %F0%9F%93%BA %E2%80%94 (Remove rounded design + Return YouTube dislikes):445
(anonymous) @ userscript:GM-https://github.com/adamlui/YouTube%E2%84%A2 Classic %F0%9F%93%BA %E2%80%94 (Remove rounded design + Return YouTube dislikes):477
(anonymous) @ userscript:GM-https://github.com/adamlui/YouTube%E2%84%A2 Classic %F0%9F%93%BA %E2%80%94 (Remove rounded design + Return YouTube dislikes):2208
(anonymous) @ userscript:GM-https://github.com/adamlui/YouTube%E2%84%A2 Classic %F0%9F%93%BA %E2%80%94 (Remove rounded design + Return YouTube dislikes):2213
Promise.then (async)
(anonymous) @ userscript:GM-https://github.com/adamlui/YouTube%E2%84%A2 Classic %F0%9F%93%BA %E2%80%94 (Remove rounded design + Return YouTube dislikes):477
(anonymous) @ userscript:GM-https://github.com/adamlui/YouTube%E2%84%A2 Classic %F0%9F%93%BA %E2%80%94 (Remove rounded design + Return YouTube dislikes):2208
(anonymous) @ userscript:GM-https://github.com/adamlui/YouTube%E2%84%A2 Classic %F0%9F%93%BA %E2%80%94 (Remove rounded design + Return YouTube dislikes):2213
userscript:GM-https://github.com/adamlui/YouTube%E2%84%A2 Classic %F0%9F%93%BA %E2%80%94 (Remove rounded design + Return YouTube dislikes):449 Uncaught (in promise) TypeError: Failed to execute 'observe' on 'MutationObserver': parameter 1 is not of type 'Node'.
    at userscript:GM-https://github.com/adamlui/YouTube%E2%84%A2 Classic %F0%9F%93%BA %E2%80%94 (/Remove rounded design + Return YouTube dislikes):449:16
    at new Promise (<anonymous>)
    at waitForElem (userscript:GM-https://github.com/adamlui/YouTube%E2%84%A2 Classic %F0%9F%93%BA %E2%80%94 (/Remove rounded design + Return YouTube dislikes):445:16)
    at userscript:GM-https://github.com/adamlui/YouTube%E2%84%A2 Classic %F0%9F%93%BA %E2%80%94 (/Remove rounded design + Return YouTube dislikes):478:5
    at userscript:GM-https://github.com/adamlui/YouTube%E2%84%A2 Classic %F0%9F%93%BA %E2%80%94 (/Remove rounded design + Return YouTube dislikes):2208:3
    at userscript:GM-https://github.com/adamlui/YouTube%E2%84%A2 Classic %F0%9F%93%BA %E2%80%94 (/Remove rounded design + Return YouTube dislikes):2213:3
(anonymous) @ userscript:GM-https://github.com/adamlui/YouTube%E2%84%A2 Classic %F0%9F%93%BA %E2%80%94 (Remove rounded design + Return YouTube dislikes):449
waitForElem @ userscript:GM-https://github.com/adamlui/YouTube%E2%84%A2 Classic %F0%9F%93%BA %E2%80%94 (Remove rounded design + Return YouTube dislikes):445
(anonymous) @ userscript:GM-https://github.com/adamlui/YouTube%E2%84%A2 Classic %F0%9F%93%BA %E2%80%94 (Remove rounded design + Return YouTube dislikes):478
(anonymous) @ userscript:GM-https://github.com/adamlui/YouTube%E2%84%A2 Classic %F0%9F%93%BA %E2%80%94 (Remove rounded design + Return YouTube dislikes):2208
(anonymous) @ userscript:GM-https://github.com/adamlui/YouTube%E2%84%A2 Classic %F0%9F%93%BA %E2%80%94 (Remove rounded design + Return YouTube dislikes):2213
Promise.then (async)
(anonymous) @ userscript:GM-https://github.com/adamlui/YouTube%E2%84%A2 Classic %F0%9F%93%BA %E2%80%94 (Remove rounded design + Return YouTube dislikes):478
(anonymous) @ userscript:GM-https://github.com/adamlui/YouTube%E2%84%A2 Classic %F0%9F%93%BA %E2%80%94 (Remove rounded design + Return YouTube dislikes):2208
(anonymous) @ userscript:GM-https://github.com/adamlui/YouTube%E2%84%A2 Classic %F0%9F%93%BA %E2%80%94 (Remove rounded design + Return YouTube dislikes):2213
userscript:GM-https://github.com/adamlui/YouTube%E2%84%A2 Classic %F0%9F%93%BA %E2%80%94 (Remove rounded design + Return YouTube dislikes):449 Uncaught (in promise) TypeError: Failed to execute 'observe' on 'MutationObserver': parameter 1 is not of type 'Node'.
    at userscript:GM-https://github.com/adamlui/YouTube%E2%84%A2 Classic %F0%9F%93%BA %E2%80%94 (/Remove rounded design + Return YouTube dislikes):449:16
    at new Promise (<anonymous>)
    at waitForElem (userscript:GM-https://github.com/adamlui/YouTube%E2%84%A2 Classic %F0%9F%93%BA %E2%80%94 (/Remove rounded design + Return YouTube dislikes):445:16)
    at userscript:GM-https://github.com/adamlui/YouTube%E2%84%A2 Classic %F0%9F%93%BA %E2%80%94 (/Remove rounded design + Return YouTube dislikes):1677:5
    at userscript:GM-https://github.com/adamlui/YouTube%E2%84%A2 Classic %F0%9F%93%BA %E2%80%94 (/Remove rounded design + Return YouTube dislikes):2208:3
    at userscript:GM-https://github.com/adamlui/YouTube%E2%84%A2 Classic %F0%9F%93%BA %E2%80%94 (/Remove rounded design + Return YouTube dislikes):2213:3
(anonymous) @ userscript:GM-https://github.com/adamlui/YouTube%E2%84%A2 Classic %F0%9F%93%BA %E2%80%94 (Remove rounded design + Return YouTube dislikes):449
waitForElem @ userscript:GM-https://github.com/adamlui/YouTube%E2%84%A2 Classic %F0%9F%93%BA %E2%80%94 (Remove rounded design + Return YouTube dislikes):445
(anonymous) @ userscript:GM-https://github.com/adamlui/YouTube%E2%84%A2 Classic %F0%9F%93%BA %E2%80%94 (Remove rounded design + Return YouTube dislikes):1677
(anonymous) @ userscript:GM-https://github.com/adamlui/YouTube%E2%84%A2 Classic %F0%9F%93%BA %E2%80%94 (Remove rounded design + Return YouTube dislikes):2208
(anonymous) @ userscript:GM-https://github.com/adamlui/YouTube%E2%84%A2 Classic %F0%9F%93%BA %E2%80%94 (Remove rounded design + Return YouTube dislikes):2213
Promise.then (async)
(anonymous) @ userscript:GM-https://github.com/adamlui/YouTube%E2%84%A2 Classic %F0%9F%93%BA %E2%80%94 (Remove rounded design + Return YouTube dislikes):1677
(anonymous) @ userscript:GM-https://github.com/adamlui/YouTube%E2%84%A2 Classic %F0%9F%93%BA %E2%80%94 (Remove rounded design + Return YouTube dislikes):2208
(anonymous) @ userscript:GM-https://github.com/adamlui/YouTube%E2%84%A2 Classic %F0%9F%93%BA %E2%80%94 (Remove rounded design + Return YouTube dislikes):2213

adamlui · 2024-10-30T11:29:22Z

Actually screenshot is more readable, but can you change the latest version document-start to document-end again, and if new tab doesn't load logo screenshot console

mhwgoo · 2024-10-30T12:45:31Z

Changed back to document-end, on second tab, it seemed the userscript did not get called. First tab was all good.

adamlui · 2024-10-30T13:13:05Z

What about when you refresh second tab? Also you could try installing another userscript, then open new tab and see if phenomenon occurs (if so this is qutebrowser bug worthy of reporting to him) because second console shows no user.js errors

adamlui · 2024-10-30T13:14:53Z

You could create a userscript that matches YouTube, then see if second tab your script loads

mhwgoo · 2024-10-30T13:56:24Z

My code:

console.log("this is kate")

var ads = document.getElementsByTagName("ytd-ad-slot-renderer");

window.addEventListener('animationstart', function() {
    if (ads) {
        for (var i = 0; i < ads.length; i++ ) {
            ads[i].parentNode.parentNode.remove();
        }
    }

    console.log("animationstart done")
    ads = document.getElementsByTagName("ytd-ad-slot-renderer");
});

window.addEventListener('animationend', function() {
    if (ads) {
        for (var i = 0; i < ads.length; i++ ) {
            ads[i].parentNode.parentNode.remove();
        }
    }

    console.log("animationend done")
    ads = document.getElementsByTagName("ytd-ad-slot-renderer");
});

window.addEventListener('load', function() {
    if (ads) {
        for (var i = 0; i < ads.length; i++ ) {
            ads[i].parentNode.parentNode.remove();
        }
    }

    console.log("load done")
    ads = document.getElementsByTagName("ytd-ad-slot-renderer");
});

Screenshot, the script was called and log message printed, on second tab (see the right bottom):

adamlui · 2024-10-30T14:11:45Z

Does it happen with document-end vs. document-start

mhwgoo · 2024-10-30T14:14:41Z

I reused your greasemonkey starting syntax, and changed to document-start:

// ==UserScript==
// @name          YouTube™ Classic 📺 — (Remove rounded design + Return YouTube dislikes)
// @version       2024.10.30.3
// @author        Adam Lui, Magma_Craft, Anarios, JRWR, Fuim & hoothin
// @namespace     https://github.com/adamlui
// @description   Reverts YouTube to its classic design (before all the rounded corners & hidden dislikes) + redirects YouTube Shorts
// @license       MIT
// @icon          https://media.ytclassic.com/images/icon48.png
// @icon64        https://media.ytclassic.com/images/icon64.png
// @compatible    chrome
// @compatible    firefox
// @compatible    opera
// @compatible    safari
// @compatible    edge
// @match         *://*.youtube.com/*
// @grant         GM_registerMenuCommand
// @grant         GM_unregisterMenuCommand
// @grant         GM_getValue
// @grant         GM_setValue
// @run-at        document-start
// @downloadURL   https://update.greasyfork.org/scripts/456132/youtube-classic.user.js
// @updateURL     https://update.greasyfork.org/scripts/456132/youtube-classic.meta.js
// @homepageURL   https://www.ytclassic.com
// @supportURL    https://support.ytclassic.com
// ==/UserScript==

console.log("this is kate")

var ads = document.getElementsByTagName("ytd-ad-slot-renderer");

window.addEventListener('animationstart', function() {
    if (ads) {
        for (var i = 0; i < ads.length; i++ ) {
            ads[i].parentNode.parentNode.remove();
        }
    }

    console.log("animationstart done")
    ads = document.getElementsByTagName("ytd-ad-slot-renderer");
});

window.addEventListener('animationend', function() {
    if (ads) {
        for (var i = 0; i < ads.length; i++ ) {
            ads[i].parentNode.parentNode.remove();
        }
    }

    console.log("animationend done")
    ads = document.getElementsByTagName("ytd-ad-slot-renderer");
});

window.addEventListener('load', function() {
    if (ads) {
        for (var i = 0; i < ads.length; i++ ) {
            ads[i].parentNode.parentNode.remove();
        }
    }

    console.log("load done")
    ads = document.getElementsByTagName("ytd-ad-slot-renderer");
});

adamlui · 2024-10-30T14:19:09Z

And what happened? Also you should test every possible value from https://wiki.greasespot.net/Metadata_Block#@run-at for both our scripts, also without @run-at and then see which one makes both scripts work in 2nd tab

adamlui · 2024-10-30T14:20:03Z

...and the ones that cause script to not load in 2nd tab, you should report to qutebrowser

mhwgoo · 2024-10-30T14:32:55Z

I had moved your userscript out before I tested this one to avoid collisions. It worked all good except occasional transient blank boxes for 1-2 seconds as I mentioned this code two days ago.

mhwgoo · 2024-10-30T14:53:02Z

I think I may stay with this little script for a while. After I get acquainted with js, I may utilize it or contribute on your project, thanks a lot for your time and big support.

adamlui · 2024-10-30T15:46:06Z

Yes please learn js it is the best language used in so many things. Chatgpt made me very powerful at it in really short time. Also by little script you mean the one you pasted so ads go away but not round corners works in 2nd tab?

mhwgoo · 2024-10-30T16:42:39Z

Yeah that little script only does the job of cleaning ads on the fly, works on second tab, without all of your awesome features, though. It makes do, after all it's only a few lines of code.

mhwgoo · 2024-10-30T16:50:12Z

Javascript is powerful, but I have to say I don't like it:) It makes doing creepy and evil activities extremely easy for people without good intentions, websites not as good as before. I think that may be one reason you call your project "youtube classic", and revert to the good old appearance.

mhwgoo · 2024-10-30T16:59:19Z

But from chatting with you, I got to learn that js actually has an observe() method, attached to 3 observer classes. Really good to know.

adamlui · 2024-10-30T17:39:04Z

When I first made the script I just cobbled together code from co-authors listed in the meta because I was not superpowerful at it as now. But thousands of users started growing, and the CSS needs constant maintaining to keep up with the UI changes. But I have COVID so am hesitant to clean up the script using my new powers, because then it will become a beast I am obligated to feed. But if you learn js you could co-maintain it especially if you use YouTube a lot so can keep up with the changes

mhwgoo · 2024-10-30T18:11:09Z

I might only learn the amount enough to tweak a script to solve a specific problem I face in satisfying some needs. No more. I wouldn't like to put too much time in js, not a big fan of it, or hate it, to exaggerate a bit, because to some extent it is js that makes my web surfing experience a lot bitter.

adamlui · 2024-10-30T18:16:48Z

But it is js that can fix it

mhwgoo · 2024-10-30T18:29:16Z

One might know how to solve a problem from universal programming mindset, the rest is just copying some syntax. No need to especially learn this language which has already gone in the weirder and weirder direction, in my opinion.

adamlui · 2024-10-30T18:54:32Z

Ok understood

adamlui added the enhancement label Oct 26, 2024

adamlui added bug and removed enhancement labels Oct 27, 2024

adamlui added the enhancement label Oct 28, 2024

adamlui added a commit to adamlui/youtube-classic that referenced this issue Oct 28, 2024

Updated selector for hiding Shorts sections (adamlui/userscripts#106)

c04391c

adamlui added a commit to adamlui/youtube-classic that referenced this issue Oct 28, 2024

Added ad removal to homepage (adamlui/userscripts#106)

b46849c

adamlui pushed a commit that referenced this issue Oct 28, 2024

Added ad removal to homepage (#106) ↞ [auto-sync from `adamlui/youtub…

662e1f9

…e-classic`]

adamlui added a commit to adamlui/youtube-classic that referenced this issue Oct 30, 2024

Added wait for <html> load before observing for homepage ads (adamlui…

ac3b19f

…/userscripts#106)

adamlui pushed a commit that referenced this issue Oct 30, 2024

Added wait for <html> load before observing for homepage ads (#106) ↞…

adcf1b5

… [auto-sync from `adamlui/youtube-classic`]

adamlui mentioned this issue Oct 30, 2024

YouTube Classic triggers observer errors in qutebrowser adamlui/youtube-classic#44

Closed

could you make scrollbar on the right hidden as it's a bit distracting when watching videos and a video web page is not that long to need it. [youtube classic] #106

could you make scrollbar on the right hidden as it's a bit distracting when watching videos and a video web page is not that long to need it. [youtube classic] #106

Comments

mhwgoo commented Oct 25, 2024 • edited Loading

adamlui commented Oct 26, 2024

mhwgoo commented Oct 26, 2024 • edited Loading

adamlui commented Oct 27, 2024

mhwgoo commented Oct 27, 2024 • edited Loading

mhwgoo commented Oct 28, 2024

adamlui commented Oct 28, 2024 • edited Loading

mhwgoo commented Oct 28, 2024 • edited Loading

adamlui commented Oct 28, 2024

adamlui commented Oct 28, 2024

mhwgoo commented Oct 28, 2024 • edited Loading

adamlui commented Oct 28, 2024

adamlui commented Oct 28, 2024

adamlui commented Oct 28, 2024

adamlui commented Oct 28, 2024

adamlui commented Oct 28, 2024

mhwgoo commented Oct 28, 2024 • edited Loading

adamlui commented Oct 28, 2024

mhwgoo commented Oct 28, 2024 • edited Loading

mhwgoo commented Oct 28, 2024 • edited Loading

mhwgoo commented Oct 28, 2024 • edited Loading

adamlui commented Oct 28, 2024

adamlui commented Oct 28, 2024

mhwgoo commented Oct 29, 2024

mhwgoo commented Oct 29, 2024

adamlui commented Oct 30, 2024 • edited Loading

mhwgoo commented Oct 30, 2024

adamlui commented Oct 30, 2024

adamlui commented Oct 30, 2024 • edited Loading

mhwgoo commented Oct 30, 2024 • edited Loading

adamlui commented Oct 30, 2024

mhwgoo commented Oct 30, 2024 • edited Loading

adamlui commented Oct 30, 2024 • edited Loading

adamlui commented Oct 30, 2024

mhwgoo commented Oct 30, 2024 • edited Loading

adamlui commented Oct 30, 2024

mhwgoo commented Oct 30, 2024

adamlui commented Oct 30, 2024

adamlui commented Oct 30, 2024

mhwgoo commented Oct 30, 2024

mhwgoo commented Oct 30, 2024

adamlui commented Oct 30, 2024

mhwgoo commented Oct 30, 2024

mhwgoo commented Oct 30, 2024 • edited Loading

mhwgoo commented Oct 30, 2024

adamlui commented Oct 30, 2024

mhwgoo commented Oct 30, 2024 • edited Loading

adamlui commented Oct 30, 2024

mhwgoo commented Oct 30, 2024

adamlui commented Oct 30, 2024

mhwgoo commented Oct 25, 2024 •

edited

Loading

mhwgoo commented Oct 26, 2024 •

edited

Loading

mhwgoo commented Oct 27, 2024 •

edited

Loading

adamlui commented Oct 28, 2024 •

edited

Loading

mhwgoo commented Oct 28, 2024 •

edited

Loading

mhwgoo commented Oct 28, 2024 •

edited

Loading

mhwgoo commented Oct 28, 2024 •

edited

Loading

mhwgoo commented Oct 28, 2024 •

edited

Loading

mhwgoo commented Oct 28, 2024 •

edited

Loading

mhwgoo commented Oct 28, 2024 •

edited

Loading

adamlui commented Oct 30, 2024 •

edited

Loading

adamlui commented Oct 30, 2024 •

edited

Loading

mhwgoo commented Oct 30, 2024 •

edited

Loading

mhwgoo commented Oct 30, 2024 •

edited

Loading

adamlui commented Oct 30, 2024 •

edited

Loading

mhwgoo commented Oct 30, 2024 •

edited

Loading

mhwgoo commented Oct 30, 2024 •

edited

Loading

mhwgoo commented Oct 30, 2024 •

edited

Loading