Use a boto session rather than global client

adammcdonagh · Oct 20, 2023 · 6e721bc · 6e721bc
1 parent d9c102e
commit 6e721bc
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/src/opentaskpy/addons/aws/remotehandlers/ecsfargate.py b/src/opentaskpy/addons/aws/remotehandlers/ecsfargate.py
@@ -44,7 +44,9 @@ def __init__(self, spec: dict):
         if os.environ.get("AWS_ENDPOINT_URL"):
             kwargs["endpoint_url"] = os.environ.get("AWS_ENDPOINT_URL")
 
-        self.ecs_client = boto3.client("ecs", **kwargs)
+        session = boto3.session.Session()
+
+        self.ecs_client = session.client("ecs", **kwargs)
 
     def kill(self) -> None:
         """Kill the fargate task function.

diff --git a/tests/test_remotehandler_ecsfargate_execution.py b/tests/test_remotehandler_ecsfargate_execution.py
@@ -7,7 +7,6 @@
 import botocore.exceptions
 import opentaskpy.otflogging
 import pytest
-from moto import mock_ecs
 from opentaskpy.taskhandlers import execution
 
 from opentaskpy.addons.aws.remotehandlers.ecsfargate import FargateTaskExecution
@@ -83,13 +82,15 @@ def credentials_aws_dev():
             del os.environ["AWS_ENDPOINT_URL"]
 
 
-def create_ecs_cluster():
+def create_ecs_cluster(credentials_aws_dev):
     # Print all env vars that start with AWS
     for key, value in os.environ.items():
         if key.startswith("AWS"):
             print(f"{key}: {value}")
 
-    client = boto3.client("ecs")
+    session = boto3.session.Session()
+
+    client = session.client("ecs")
     # Check to see if the ECS cluster exists
     try:
         response = client.describe_clusters(clusters=["test_cluster"])
@@ -108,7 +109,9 @@ def create_ecs_cluster():
 
 
 def create_fargate_task():
-    client = boto3.client("ecs")
+    session = boto3.session.Session()
+
+    client = session.client("ecs")
 
     # Check to see if the task definition exists
     try: