Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STS Token fixes & S3 local copy fix #35

Merged
merged 12 commits into from
Apr 12, 2024
Merged

Conversation

adammcdonagh
Copy link
Owner

  • Fix issue where too many files were being uploaded from worker
  • Properly fix STS token refresh code
  • Linting updates for ruff
  • Added unused argument linting check back in, which would have caught point 1

@adammcdonagh
Copy link
Owner Author

TODO: Refactor AWS client and temporary creds code to remove redundant code in s3.py, fargate.py & lamda.py

Copy link

codecov bot commented Apr 11, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 84.15%. Comparing base (b2747d2) to head (da7e61c).

Files Patch % Lines
...opentaskpy/addons/aws/remotehandlers/ecsfargate.py 86.36% 3 Missing ⚠️
src/opentaskpy/addons/aws/remotehandlers/lambda.py 86.95% 3 Missing ⚠️
src/opentaskpy/addons/aws/remotehandlers/s3.py 92.68% 3 Missing ⚠️
src/opentaskpy/addons/aws/remotehandlers/creds.py 95.83% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
+ Coverage   78.94%   84.15%   +5.20%     
==========================================
  Files           4        4              
  Lines         456      448       -8     
==========================================
+ Hits          360      377      +17     
+ Misses         96       71      -25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adammcdonagh adammcdonagh marked this pull request as ready for review April 12, 2024 17:29
@adammcdonagh adammcdonagh merged commit 0c7e0ca into main Apr 12, 2024
26 checks passed
@adammcdonagh adammcdonagh deleted the bugfix/local-to-s3-uploads branch April 12, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant