Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON schema improvements #43

Merged
merged 2 commits into from
Jun 21, 2024
Merged

JSON schema improvements #43

merged 2 commits into from
Jun 21, 2024

Conversation

adammcdonagh
Copy link
Owner

This pull request includes improvements to the JSON schema. It allows for a blank postCopyAction or "none" value, which can be useful when using the same job definition for multiple environments. It also prevents S3 source directories from starting or ending with a "/".

Copy link

codecov bot commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.32%. Comparing base (9f5c398) to head (6f2f5b5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #43   +/-   ##
=======================================
  Coverage   84.32%   84.32%           
=======================================
  Files           4        4           
  Lines         453      453           
=======================================
  Hits          382      382           
  Misses         71       71           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adammcdonagh adammcdonagh merged commit 47e1073 into main Jun 21, 2024
26 checks passed
@adammcdonagh adammcdonagh deleted the feat/allow-none-pca branch June 21, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant