Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update botocore read_timeout #45

Merged
merged 2 commits into from
Jul 11, 2024
Merged

Conversation

adammcdonagh
Copy link
Owner

This pull request updates the get_aws_client function in creds.py to include a config parameter that allows overriding the default read_timeout value.

This can be set in the protocol definition using botocoreReadTimeout property

Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.49%. Comparing base (47e1073) to head (cbd0b1f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #45      +/-   ##
==========================================
+ Coverage   84.32%   84.49%   +0.17%     
==========================================
  Files           4        4              
  Lines         453      458       +5     
==========================================
+ Hits          382      387       +5     
  Misses         71       71              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adammcdonagh adammcdonagh merged commit 56d7468 into main Jul 11, 2024
26 checks passed
@adammcdonagh adammcdonagh deleted the feat/override-botocore-timeout branch July 11, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant