Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tags for vsphere instances #68

Merged
merged 3 commits into from
Jun 20, 2017
Merged

Add tags for vsphere instances #68

merged 3 commits into from
Jun 20, 2017

Conversation

nicgrayson
Copy link
Contributor

I didn't see tests for this section of code so I didn't add any tests. This works for me though.

@adammck
Copy link
Owner

adammck commented Jun 16, 2017

Thanks! Could you add an example to the vsphere_virtual_machine section in parser_test.go? It's turned into a sort of huge integration test of everything, which works well enough.

@nicgrayson
Copy link
Contributor Author

@adammck added test

@adammck adammck merged commit 656ee76 into adammck:master Jun 20, 2017
@adammck
Copy link
Owner

adammck commented Jun 20, 2017

Lgtm, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants