Remove default value from SynthesizedParameterSymbol constructor to f…

…ollow convention from source parameter symbols
adamperlin · Aug 11, 2022 · 26375e1 · 26375e1
1 parent c1d4482
commit 26375e1
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/src/Compilers/CSharp/Portable/Symbols/Synthesized/SynthesizedParameterSymbol.cs b/src/Compilers/CSharp/Portable/Symbols/Synthesized/SynthesizedParameterSymbol.cs
@@ -204,9 +204,8 @@ private SynthesizedParameterSymbol(
             int ordinal,
             RefKind refKind,
             DeclarationScope scope,
-            ConstantValue? defaultValue,
             string name)
-            : base(container, type, ordinal, refKind, scope, defaultValue, name)
+            : base(container, type, ordinal, refKind, scope, defaultValue: null, name)
         {
         }
 
@@ -221,9 +220,9 @@ public static ParameterSymbol Create(
             ImmutableArray<CustomModifier> refCustomModifiers = default,
             SourceComplexParameterSymbolBase? baseParameterForAttributes = null)
         {
-            if (refCustomModifiers.IsDefaultOrEmpty && baseParameterForAttributes is null)
+            if (refCustomModifiers.IsDefaultOrEmpty && baseParameterForAttributes is null && defaultValue is null)
             {
-                return new SynthesizedParameterSymbol(container, type, ordinal, refKind, scope, defaultValue, name);
+                return new SynthesizedParameterSymbol(container, type, ordinal, refKind, scope, name);
             }
 
             return new SynthesizedComplexParameterSymbol(