-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Force gha to pass #1
base: master
Are you sure you want to change the base?
Conversation
@@ -1,4 +1,5 @@ | |||
name: nf-core linting | |||
run-name: nf-core linting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
run-name: nf-core linting | |
run-name: nf-core lint |
@@ -14,7 +15,7 @@ concurrency: | |||
|
|||
jobs: | |||
changes: | |||
name: Check for changes | |||
name: check-for-changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name: check-for-changes | |
name: check-changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can't just change names because you don't like how they look 😉 These matter for the branch protection.
.github/workflows/nf-test.yml
Outdated
@@ -15,7 +16,7 @@ concurrency: | |||
|
|||
jobs: | |||
changes: | |||
name: Check for changes | |||
name: check-for-changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name: check-for-changes | |
name: check-changes |
@@ -15,7 +16,7 @@ concurrency: | |||
|
|||
jobs: | |||
changes: | |||
name: Check for changes | |||
name: check-for-changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name: check-for-changes | |
name: check-changes |
@@ -1,4 +1,5 @@ | |||
name: Pytest-workflow | |||
name: pytest-workflow | |||
run-name: pytest-workflow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
run-name: pytest-workflow | |
run-name: pytest |
@@ -28,10 +29,9 @@ jobs: | |||
with: | |||
filters: "tests/config/pytest_modules.yml" | |||
|
|||
test: | |||
pytest_workflow: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pytest_workflow: | |
pytest: |
runs-on: ubuntu-20.04 | ||
|
||
name: ${{ matrix.tags }} ${{ matrix.profile }} | ||
name: pytest-workflow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name: pytest-workflow | |
name: pytest |
.github/workflows/nf-test.yml
Outdated
@@ -28,10 +29,9 @@ jobs: | |||
with: | |||
filters: "tests/config/nftest_modules.yml" | |||
|
|||
test: | |||
nf_test: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nf_test: | |
nf-test: |
.github/workflows/code-linting.yml
Outdated
@@ -1,4 +1,4 @@ | |||
name: Code Linting | |||
name: code-linting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name: code-linting | |
name: code-lint |
.github/workflows/fix-linting.yml
Outdated
on: | ||
issue_comment: | ||
types: [created] | ||
|
||
jobs: | ||
deploy: | ||
fix_linting: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix_linting: | |
fix-linting: |
Excellent spot 🚀 I suggested some minimised names for the CI tests just so that we don't go off screen when we include module names at the end. |
@drpatelh go review nf-core#3677 if you want to actually check stuff. |
The test names are the IDs used for branch protection, so they matter in some circumstances, although they can be changed of course. |
Done!
Yep, since we are making the changes now is a good time as any. |
Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>
Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>
Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>
This reverts commit f8e5c94.
PR checklist
Closes #XXX
versions.yml
file.label
PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware