Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force gha to pass #1

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Force gha to pass #1

wants to merge 17 commits into from

Conversation

adamrtalbot
Copy link
Owner

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware

@adamrtalbot
Copy link
Owner Author

Branch protection rules:
image

@@ -1,4 +1,5 @@
name: nf-core linting
run-name: nf-core linting

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
run-name: nf-core linting
run-name: nf-core lint

@@ -14,7 +15,7 @@ concurrency:

jobs:
changes:
name: Check for changes
name: check-for-changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name: check-for-changes
name: check-changes

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can't just change names because you don't like how they look 😉 These matter for the branch protection.

@@ -15,7 +16,7 @@ concurrency:

jobs:
changes:
name: Check for changes
name: check-for-changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name: check-for-changes
name: check-changes

@@ -15,7 +16,7 @@ concurrency:

jobs:
changes:
name: Check for changes
name: check-for-changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name: check-for-changes
name: check-changes

@@ -1,4 +1,5 @@
name: Pytest-workflow
name: pytest-workflow
run-name: pytest-workflow

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
run-name: pytest-workflow
run-name: pytest

@@ -28,10 +29,9 @@ jobs:
with:
filters: "tests/config/pytest_modules.yml"

test:
pytest_workflow:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pytest_workflow:
pytest:

runs-on: ubuntu-20.04

name: ${{ matrix.tags }} ${{ matrix.profile }}
name: pytest-workflow

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name: pytest-workflow
name: pytest

@@ -28,10 +29,9 @@ jobs:
with:
filters: "tests/config/nftest_modules.yml"

test:
nf_test:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
nf_test:
nf-test:

@@ -1,4 +1,4 @@
name: Code Linting
name: code-linting

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name: code-linting
name: code-lint

on:
issue_comment:
types: [created]

jobs:
deploy:
fix_linting:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
fix_linting:
fix-linting:

@drpatelh
Copy link

Excellent spot 🚀 I suggested some minimised names for the CI tests just so that we don't go off screen when we include module names at the end.

@adamrtalbot
Copy link
Owner Author

@drpatelh go review nf-core#3677 if you want to actually check stuff.

@adamrtalbot
Copy link
Owner Author

Excellent spot 🚀 I suggested some minimised names for the CI tests just so that we don't go off screen when we include module names at the end.

The test names are the IDs used for branch protection, so they matter in some circumstances, although they can be changed of course.

@drpatelh
Copy link

@drpatelh go review nf-core#3677 if you want to actually check stuff.

Done!

The test names are the IDs used for branch protection, so they matter in some circumstances, although they can be changed of course.

Yep, since we are making the changes now is a good time as any.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants