Skip to content

Output WebP by default for core sizes #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 117 commits into
base: trunk
Choose a base branch
from
Draft

Output WebP by default for core sizes #24

wants to merge 117 commits into from

Conversation

@adamsilverstein
Copy link
Owner

@adamsilverstein adamsilverstein commented Jun 17, 2022

No description provided.

@adamsilverstein
Core patch, first pass
a96ea8a
@adamsilverstein
Store the sources meta
fa8b9ef
@adamsilverstein
Delete additional mime types in wp_delete_attachment_files
32807da
@adamsilverstein
Cleanup, remove unintended changes
c930645
@adamsilverstein
Add full size and root level meta
3db70bd
@adamsilverstein
Add alternate mime full sizes to wp_delete_attachment_files
62855be
@adamsilverstein
Update image tag output to use specified mime type.
54d4346
@adamsilverstein
Ensure full size image generated, sources populated
daaacba
@adamsilverstein
Handle the full size image in image tags
958e752
@adamsilverstein
Cleanup, documentation
80a78d1
@adamsilverstein
Unroll full sized image generation to single loop, dry out code with …
f2d0893 
…_wp_get_sources_from_meta
@adamsilverstein
remove duplicate editor construction
0822850
@adamsilverstein
Merge branch 'trunk' into add/webp-uploads
1caa589
@adamsilverstein
Add mime type support check in loops, skip trying unsupported mime ty…
bd9a90c 
…pes.

* Revert to 0 (first element) as default mime type ofr sub sizes
@adamsilverstein
Docblock improvements & cleanup
f863431
@adamsilverstein
Cleanup and match filter name to issue
cbd4ce7
@adamsilverstein
Add a new ‘wp_content_image_mimes’ filter for output
810818a
@adamsilverstein
Clean up and document image replacement approach.
892b34c
@adamsilverstein
Add default value to make_subsize functions
0d38d2e
@adamsilverstein
Add and improve tests
775f4ff
@adamsilverstein
Add mapping for PDF images to export as jpeg
e61ec6b
@adamsilverstein
Add ‘sources’ to test data, clean up tests
913c157
@adamsilverstein
Merge branch 'trunk' into add/webp-uploads
f3b30ef 
# Conflicts:
#	src/wp-admin/includes/image.php
#	tests/phpunit/tests/image/functions.php
@adamsilverstein
Test cleanup
f2cacab
@adamsilverstein
Switch all filesize calls to wp_filesize
6960704
@adamsilverstein
Use root meta filesize when available vs. recalculating
3c85bc1
@adamsilverstein
Fix test data
f383749
@adamsilverstein
Cleanup
cba3b43
@adamsilverstein
Remove mime support checks, handled downstream already
3486a08
@adamsilverstein
Improve doc blocks, tests, cleanup
0afad05
adamsilverstein and others added 21 commits March 29, 2022 08:54
@adamsilverstein @mitogh
Update src/wp-includes/post.php
133d9a6 
Co-authored-by: Crisoforo Gaspar Hernández <hello@crisoforo.com>
@adamsilverstein @mitogh
Update tests/phpunit/tests/image/functions.php
bf1c483 
Co-authored-by: Crisoforo Gaspar Hernández <hello@crisoforo.com>
@adamsilverstein @mitogh
Update src/wp-includes/class-wp-image-editor.php
4bffe64 
Co-authored-by: Crisoforo Gaspar Hernández <hello@crisoforo.com>
@adamsilverstein
phpcbf
abcab3a
@adamsilverstein
Merge branch 'trunk' into add/webp-uploads
2bd43b2 
# Conflicts:
#	src/wp-includes/media.php
@adamsilverstein
Ensure $meta['file'] set before using
790f011
@adamsilverstein
restore whitespace
416f088
@adamsilverstein
Merge branch 'trunk' into add/webp-uploads
7b400ae
@adamsilverstein
Ensure image filter skipped for test
6a894f5
@adamsilverstein
Merge branch 'trunk' into add/webp-uploads
dfd6ec4
@felixarntz
Merge branch 'trunk' into add/webp-uploads
9ea4c64
@felixarntz
Enhance separation of concerns in image generation logic, introduce m…
d191861 
…ime_type parameter and various private low-level functions to avoid duplicate and complex code.
@felixarntz
Treat the manually set mime_type class property like a fallback for t…
688d4f9 
…he mime_type method parameter.
@felixarntz
Update version numbers to 6.1.0.
503134e
@felixarntz
Ensure retry mechanism works correctly and also generates full sized …
52836e8 
…images for additional mime types.
@adamsilverstein
Merge branch 'trunk' into add/webp-uploads
47781a6 
# Conflicts:
#	src/wp-includes/media.php
#	tests/phpunit/tests/media.php
@adamsilverstein
Merge branch 'add/webp-uploads' of github.com:adamsilverstein/wordpre…
8f9b99e 
…ss-develop-fork into add/webp-uploads
@adamsilverstein
fix after merge
d75e58a
@adamsilverstein
Fixes for tests
1589bfd
@adamsilverstein
Handle an empty value for $output_mime_types: only output the origina…
4dbb3e7 
…l type.
@adamsilverstein
Improve deletion to use sources data when available, falling back to …
f24edd1 
…sizeinfo data
@adamsilverstein adamsilverstein force-pushed the add/webp-uploads-only-core-default branch from dd30c5a to 68049c8 Compare June 17, 2022 16:24
@adamsilverstein adamsilverstein force-pushed the add/webp-uploads-only-core-default branch from 68049c8 to 90c5196 Compare June 17, 2022 22:27
@adamsilverstein adamsilverstein force-pushed the add/webp-uploads branch 2 times, most recently from f5c73f6 to f4033b6 Compare July 12, 2022 21:41
@adamsilverstein adamsilverstein changed the base branch from add/webp-uploads to trunk June 20, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adamsilverstein @felixarntz