-
Notifications
You must be signed in to change notification settings - Fork 1
Implement ProcessStartOptions.CreateSuspended and SafeChildProcessHandle.Resume #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>
Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>
Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>
adamsitnik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot overall it LGTM, but we need to fix one test failure PTAL at my comments
| // Normalize paths for comparison (handle case differences on Windows) | ||
| string normalizedOutput = output?.Trim().Replace('\\', '/').ToLowerInvariant() ?? ""; | ||
| string normalizedExpected = tempDir.Replace('\\', '/').ToLowerInvariant(); | ||
|
|
||
| Assert.Equal(normalizedExpected, normalizedOutput); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's better to do the following:
- store the
DirectoryInforeturned byDirectory.CreateDirectory(tempDir); - use it's FullName as expected output for the assert
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in c69f2fd. Now storing the DirectoryInfo returned by Directory.CreateDirectory() and using its FullName property for the expected path comparison.
Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>
|
@copilot solve the merge conflicts |
CreateSuspendedproperty toProcessStartOptionsResume()method toSafeChildProcessHandleOriginal prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.