Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow import of PDF as full-page in the app #464

Closed
5 tasks
adamwulf opened this issue May 26, 2014 · 3 comments
Closed
5 tasks

allow import of PDF as full-page in the app #464

adamwulf opened this issue May 26, 2014 · 3 comments

Comments

@adamwulf
Copy link
Owner

when loading pdf:

i need to decide how i should handle pdfs with 1 page vs pdfs with multiples pages

another option would be to import the pdf as the background to a page, but that'd also make it hard to import 2 pages and put the side by side and compare them. i should probably default to scraps, and the user can zoom the scrap to full page if they want.

When cutting scraps out of the base page, I should add a white cashapelayer for each cut. I can then merge those paths on a background thread into fewer shapes of possible.

This is related to multiple stacks #44.

@adamwulf adamwulf added this to the Alpha v0.7.0 milestone May 26, 2014
@adamwulf adamwulf modified the milestones: Alpha v0.8.0, Alpha v0.7.0 Jun 4, 2014
@adamwulf adamwulf modified the milestones: Alpha v0.8.1, Alpha v0.8.0 Jul 21, 2014
@adamwulf adamwulf modified the milestone: Icebox Oct 6, 2014
@adamwulf
Copy link
Owner Author

the commit in cbcf351d02452b7c4e7800d28411abdba7207f62 has the import file type for the plist

@adamwulf adamwulf modified the milestones: v1.4.0, Icebox May 28, 2015
@adamwulf adamwulf changed the title allow import of PDF allow import of PDF as full-page in the app Jun 10, 2015
@adamwulf adamwulf removed this from the v1.4.0 milestone Jun 10, 2015
@adamwulf adamwulf added this to the v2.0.0 milestone Jan 6, 2016
@adamwulf
Copy link
Owner Author

I should use the tiled PDF viewer in ZoomingPDFViewer to display the pdf as the page background.

ideally, i would:

  • create new PDF with only that 1 page
  • save the one page in the page's assets folder
  • make page backgrounds abstract so that they don't rely on an image view if its not an image
  • render that pdf with the TiledPDFView for the page background

@adamwulf
Copy link
Owner Author

duplicate of #1169

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant