[javascript] Add test case for pmd#4129

adangel · Oct 31, 2024 · ec8aa18 · ec8aa18
1 parent 3dcddba
commit ec8aa18
Showing 1 changed file with 43 additions and 0 deletions.
diff --git a/...est/resources/net/sourceforge/pmd/lang/ecmascript/rule/codestyle/xml/UnnecessaryBlock.xml b/...est/resources/net/sourceforge/pmd/lang/ecmascript/rule/codestyle/xml/UnnecessaryBlock.xml
@@ -336,6 +336,49 @@ async function run2(){
         await client.close()
     }
 }
+]]></code>
+    </test-code>
+
+    <test-code>
+        <description>#4129 [javascript] UnnecessaryBlock FP for function declaration</description>
+        <expected-problems>0</expected-problems>
+        <code><![CDATA[
+const getAdditionalTagTrackingImpressionObj = (
+    profileId,
+    cityName,
+    tracking,
+    isAdditionalTagsAndSlicerAbTest
+) => {
+    const action = isAdditionalTagsAndSlicerAbTest
+        ? `TagShown${tracking}`
+        : ADDITIONAL_TAG_NOT_SHOWN_ACTION;
+    return { // unnecessary block false positive here
+        gaCat: SEARCH_PAGE_TRACKING_CATEGORY,
+        gaActImp: action,
+        gaLblImp: `profileId=${profileId}|Cityname=${cityName}`,
+        once: true,
+        trackImpression: true,
+    };
+};
+
+/* export is not supported by rhino and produces a syntax error/empty statement */
+export const getAdditionalTagTrackingImpressionObj = (
+    profileId,
+    cityName,
+    tracking,
+    isAdditionalTagsAndSlicerAbTest
+) => {
+    const action = isAdditionalTagsAndSlicerAbTest
+        ? `TagShown${tracking}`
+        : ADDITIONAL_TAG_NOT_SHOWN_ACTION;
+    return { // unnecessary block false positive here
+        gaCat: SEARCH_PAGE_TRACKING_CATEGORY,
+        gaActImp: action,
+        gaLblImp: `profileId=${profileId}|Cityname=${cityName}`,
+        once: true,
+        trackImpression: true,
+    };
+};
 ]]></code>
     </test-code>
 </test-data>