Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename status code value, improve consistency #1258

Merged
merged 2 commits into from
Jun 21, 2022
Merged

Rename status code value, improve consistency #1258

merged 2 commits into from
Jun 21, 2022

Conversation

danieljanes
Copy link
Member

  • Rename GET_PARAMETERS_NOT_IMPLEMENTED to GET_PROPERTIES_NOT_IMPLEMENTED
  • Reorder fields in transport.proto to match order in other parts of the codebase

@danieljanes danieljanes mentioned this pull request Jun 18, 2022
Merged
@danieljanes danieljanes enabled auto-merge (squash) June 18, 2022 12:47
@danieljanes danieljanes mentioned this pull request Jun 18, 2022
Merged
@danieljanes danieljanes merged commit 6b3bd3e into main Jun 21, 2022
@danieljanes danieljanes deleted the proto-consistency branch June 21, 2022 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanertopal tanertopal tanertopal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danieljanes @tanertopal