Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make client methods optional #1277

Merged
merged 13 commits into from
Jul 14, 2022
Merged

Make client methods optional #1277

merged 13 commits into from
Jul 14, 2022

Conversation

danieljanes
Copy link
Member

No description provided.

@danieljanes danieljanes marked this pull request as ready for review July 12, 2022 09:39
tanertopal
tanertopal requested changes Jul 13, 2022
View reviewed changes
Copy link
Member

@tanertopal tanertopal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from one question I have it looks good to me.

src/py/flwr/client/app.py Outdated Show resolved Hide resolved
tanertopal
tanertopal approved these changes Jul 14, 2022
View reviewed changes
Copy link
Member

@tanertopal tanertopal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@tanertopal tanertopal merged commit 7aa36c4 into main Jul 14, 2022
@tanertopal tanertopal deleted the make-client-methods-optional branch July 14, 2022 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanertopal tanertopal tanertopal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danieljanes @tanertopal