-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flower Baseline: FedAvg MNIST #1497
Conversation
@danieljanes What I've already tried and tested for the mypy error :
|
I just changed the name of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, I left a few comments on some details. In addition to that:
- Remove the
.5
from the distributed validation plot - Add two empty lines after each module docstring (before the imports)
- Add tests, esp. for model and dataset
What does this implement/fix? Explain your changes.
Adds a new baseline for MNIST using a CNN in a federated setting.