Fix typos in Client and NumPyClient tutorial #1710

[techwizrd]

In Step 2, replace config with ins.config in evaluate() and ensure simulation is calling the client_fn corresponding to the Client-based client.

Reference Issues/PRs

Fixes #1710

What does this implement/fix? Explain your changes.

This PR fixes several typos in Step 2: Moving from NumPyClient to Client of the Client and NumPyClient tutorial.

1. When defining the fit() function for Client, it uses ins.config but the evaluate function erroneously uses just config:

    def evaluate(self, ins: EvaluateIns) -> EvaluateRes:
        print(f"[Client {self.cid}] evaluate, config: {config}")

This leads to a NameError:

    print(f"[Client {self.cid}] evaluate, config: {config}")
NameError: name 'config' is not defined

This PR fixes the NameError by replacing config with ins.config.

2. Additionally, the tutorial asks the user to run the example using the new Client-based client, but the simulation calls numpyclient_fn instead of client_fn.

fl.simulation.start_simulation(
    client_fn=numpyclient_fn,
    num_clients=2,
    config=fl.server.ServerConfig(num_rounds=3),
    client_resources=client_resources,
)

This simulation will run the NumPyClient-based client rather than the new Client-based client. This PR fixes this by replacing the call to numpyclient_fn with client_fn.

Any other comments?

[tanertopal]

Thank you! Looks good to me!

[tanertopal]

Thank you for your contribution @techwizrd