Add FedTrimmedMean strategy #1769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edogab33
reviewed
Apr 8, 2023
edogab33
reviewed
Apr 8, 2023
edogab33
reviewed
Apr 8, 2023
edogab33
reviewed
Apr 8, 2023
|
Hi @m-danilow, I'm not a team of Flower (just a simple contributor) but I've posted some comments to help you with the PR. Hope you find them useful. |
|
Hi @edogab33, Thank you for your input, I modified part of the code as suggested :) |
|
Thanks for the PR @m-danilow & thanks for the early review @edogab33 ! At first glance, the PR seems to be in good shape. Let me know if you need help with getting the CI to pass. |
|
Hi @danieljanes, Yes, I would need help because when I execute the docformatter command locally it doesn't return me any errors... |
|
Hi @m-danilow! I will merge your PR into a new branch, so I can make modifications to fix the tests before merging it into main. Thanks for your contribution! 🌼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
#1610
What does this implement/fix? Explain your changes.
A strategy that removes the indicated percentage of the largest and smallest weights from the local models received by the server and finally averages their values to create a new global model
Any other comments?
Please check TODO comments and I would also need some guidance in fixing CI ;)