Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve docs to show how good vs bad PR titles should be written #1872

Merged
merged 5 commits into from
May 15, 2023

Conversation

tanertopal
Copy link
Member

@tanertopal tanertopal commented May 15, 2023

Issue

Description

Often PR titles could be more descriptive, so this PR aims to add documentation which gives examples on how to write a good PR title.

Checklist

@tanertopal tanertopal force-pushed the improve_contributor_getting_started_doc branch from edae12e to 89603b7 Compare May 15, 2023 11:16
@tanertopal tanertopal marked this pull request as ready for review May 15, 2023 12:34
Copy link
Member

@danieljanes danieljanes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, I added some small ideas

doc/source/first-time-contributors.rst Outdated Show resolved Hide resolved
doc/source/first-time-contributors.rst Outdated Show resolved Hide resolved
doc/source/first-time-contributors.rst Outdated Show resolved Hide resolved
tanertopal and others added 3 commits May 15, 2023 14:44
Co-authored-by: Daniel J. Beutel <daniel@adap.com>
Co-authored-by: Daniel J. Beutel <daniel@adap.com>
Co-authored-by: Daniel J. Beutel <daniel@adap.com>
@danieljanes danieljanes merged commit c665cb1 into main May 15, 2023
@danieljanes danieljanes deleted the improve_contributor_getting_started_doc branch May 15, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants