Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Bulyan (#1817) #1891

Merged
merged 47 commits into from
Nov 16, 2023
Merged

Implement Bulyan (#1817) #1891

merged 47 commits into from
Nov 16, 2023

Conversation

adam-narozniak
Copy link
Member

No description provided.

edogab33 and others added 8 commits May 23, 2023 12:47
@edogab33 @danieljanes
Implement Bulyan (#1817)
643abc3 
* Initial commit

* Initial commit

* Fix bugs

* Add tests and fix bugs

* Remove prints

* Formatting

---------

Co-authored-by: Daniel J. Beutel <daniel@adap.com>
@adam-narozniak
Fix tests
a9390ae
@adam-narozniak
Remove redundant warning
21b4829
@adam-narozniak
Reference the arxiv page not the pdf directly
1ef78a0
@adam-narozniak
Add Bulyan strategy to changelog
0cdd39b
@adam-narozniak
Fix mypy tests
23dcf0a
@adam-narozniak
Fix mypy tests
3e5d3f9
@adam-narozniak
Fix formatting
4aaddfb
@adam-narozniak adam-narozniak marked this pull request as ready for review May 23, 2023 12:10
@adam-narozniak adam-narozniak enabled auto-merge (squash) May 23, 2023 12:11
danieljanes
danieljanes requested changes May 24, 2023
View reviewed changes
Copy link
Member

@danieljanes danieljanes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! I added two comments to improve the tests a bit.

src/py/flwr/server/strategy/bulyan_test.py Outdated Show resolved Hide resolved
src/py/flwr/server/strategy/bulyan_test.py Outdated Show resolved Hide resolved
@adam-narozniak adam-narozniak marked this pull request as draft May 25, 2023 08:41
auto-merge was automatically disabled May 25, 2023 08:41

Pull request was converted to draft

@edogab33 edogab33 mentioned this pull request Sep 23, 2023
Open
jafermarq
jafermarq approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@jafermarq jafermarq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ready.

@jafermarq jafermarq enabled auto-merge (squash) November 16, 2023 14:18
danieljanes
danieljanes approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@danieljanes danieljanes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @edogab33 @adam-narozniak @jafermarq !!

@jafermarq jafermarq merged commit c3cf430 into main Nov 16, 2023
26 checks passed
@jafermarq jafermarq deleted the bulyan-strategy branch November 16, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jafermarq jafermarq jafermarq approved these changes

@danieljanes danieljanes danieljanes approved these changes

@tanertopal tanertopal Awaiting requested review from tanertopal tanertopal is a code owner

Assignees

@danieljanes danieljanes

@jafermarq jafermarq

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adam-narozniak @danieljanes @jafermarq @edogab33