Return Node
instances from GetNodes
#1936
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Description
The Driver API returns individual
int
node IDs, not fullNode
instances. When scheduling aTask
, one has to construct a fullNode
instance (setting thenode_id
and theanonymous
flag). Changes to theNode
message are not reflected inGetNodes
and it is unclear how additionalNode
properties would be communicated to the driver script.Related issues/PRs
None
Proposal
Explanation
If
GetNodes
returned fullNode
instances, one could just sample from that list and set one of theNode
instances as theconsumer
of the newTask
. Changes to theNode
message (e.g., additional properties) would automatically be reflected inGetNodes
.This PR returns full
Node
instances instead ofint
node IDs fromGetNodes
.Checklist
#contributions
)Any other comments?