Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add French translation to docs (no deployement) #2201

Closed
wants to merge 12 commits into from

Conversation

charlesbvll
Copy link
Member

@charlesbvll charlesbvll commented Aug 9, 2023

Issue

Description

We currently have no way of translating the docs.

Related issues/PRs

#2060 Needs to be merged first

Proposal

Explanation

This PR adds make commands to generate .po files, suitable for translation. And also adds the .po files with the translation for French. Note that the translation is not final, some sentences will need to be improved.

Checklist

  • Implement proposed change
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Any other comments?

This PR by itself won't change any existing behavior, nor will it deploy anything on the doc pages. It just provides new backend functionality, upcoming PRs will be responsible for visible changes.

In order to build everything, inside doc/ you can run make build-deploy version=v1.4.0. Note that the versioning links won't work as they use the actual flower.dev domain URLs, but everything will be accessible through the file system.

@charlesbvll charlesbvll changed the title Generate translatable doc files Add French translation to docs (no deployement) Aug 11, 2023
@charlesbvll charlesbvll marked this pull request as ready for review August 11, 2023 15:27
@charlesbvll
Copy link
Member Author

Closing in favor of #2262.

@charlesbvll charlesbvll deleted the add-docs-translation branch September 4, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant