Support CreateNode and DeleteNode in REST API #2283

cnxdeveloper · 2023-09-04T04:19:11Z

Issue

By default, in restful API mode, Flower only supports clients running as anonymous. This makes it difficult to manage tasks and results for each client.

Description

Related issues/PRs

Proposal

Update the 2 POST API requests to create and delete a node.
Update the client code to support calling the API to create a node and delete a node.
Update the code and README in flower/examples/mt-pytorch to run and test with restful mode.

Explanation

Checklist

Any other comments?

…nction

danieljanes · 2023-09-05T13:15:43Z

Thanks for the well-scoped PR @cnxdeveloper! It looks pretty clean and easy to review, I will try to do a full review by the end of this week. In the meantime, could you already add an entry to the changelog in the Unreleased section?

cnxdeveloper · 2023-09-05T14:00:14Z

Thanks for the well-scoped PR @cnxdeveloper! It looks pretty clean and easy to review, I will try to do a full review by the end of this week. In the meantime, could you already add an entry to the changelog in the Unreleased section?

Hi @danieljanes,
I really like the Flower framework. It's easy to use and scale up. Thank you for creating such an awesome repo!
I haven't updated the changelog in the Unreleased section yet. I'll do that later today.

danieljanes

The PR is in a good shape 👍 I added some comments to align the coding style with the rest of the codebase

examples/mt-pytorch/client.py

src/py/flwr/client/rest_client/connection.py

doc/source/ref-changelog.md

examples/mt-pytorch/README.md

src/py/flwr/server/fleet/rest_rere/rest_api.py

src/py/flwr/client/rest_client/connection.py

Total agree with suggestions Co-authored-by: Daniel J. Beutel <daniel@flower.dev>

danieljanes

Thanks for the fast updates, @cnxdeveloper! I added a few comments to improve consistency and I think that we can merge the PR once they are resolved.

examples/mt-pytorch/client.py

src/py/flwr/client/rest_client/connection.py

src/py/flwr/server/fleet/rest_rere/rest_api.py

Co-authored-by: Daniel J. Beutel <daniel@flower.dev>

danieljanes · 2023-09-08T11:42:21Z

@cnxdeveloper there's a formatting error: https://github.com/adap/flower/actions/runs/6120808796/job/16614584948?pr=2283

This can be fixed by running ./dev/format.sh

cnxdeveloper · 2023-09-09T03:36:30Z

@cnxdeveloper there's a formatting error: https://github.com/adap/flower/actions/runs/6120808796/job/16614584948?pr=2283

This can be fixed by running ./dev/format.sh

Hi @danieljanes I fixed code format by script ./dev/format.sh

danieljanes

This should resolve the CI error

src/py/flwr/client/rest_client/connection.py

danieljanes · 2023-09-10T12:24:55Z

I fixed a few linter warnings, could you reformat once more @cnxdeveloper?

danieljanes · 2023-09-10T17:44:08Z

Almost there! Only formatting issues in two markdown files left: https://github.com/adap/flower/actions/runs/6138546228/job/16655523326?pr=2283#step:6:252

cnxdeveloper · 2023-09-11T03:00:31Z

Almost there! Only formatting issues in two markdown files left: https://github.com/adap/flower/actions/runs/6138546228/job/16655523326?pr=2283#step:6:252

Hi I tried to use format script to reformat these markdown files.

src/py/flwr/client/rest_client/connection.py

danieljanes

Lgtm, merging! Thanks for the contribution @cnxdeveloper 🎉

cnxdeveloper added 2 commits September 3, 2023 10:25

update flower restful api mode support create_node and delete_node fu…

640749b

…nction

update delete_node api and refactor format code

3e45539

cnxdeveloper requested review from danieljanes and tanertopal as code owners September 4, 2023 04:19

Merge branch 'main' into main

286a38b

cnxdeveloper and others added 2 commits September 5, 2023 21:56

update Unrealeased section change log, fix warning flake8

977afec

Merge branch 'main' into main

c85c687

danieljanes requested changes Sep 7, 2023

View reviewed changes

danieljanes and others added 5 commits September 7, 2023 16:59

Merge branch 'main' into main

e3fe7b6

Apply suggestions from code review

c3ba6d8

Total agree with suggestions Co-authored-by: Daniel J. Beutel <daniel@flower.dev>

update docstring and update follow review suggestion

70464c0

Merge branch 'main' into main

de9ec69

fix flake8 whitespace

21d10d7

danieljanes requested changes Sep 8, 2023

View reviewed changes

cnxdeveloper and others added 3 commits September 8, 2023 17:44

Update examples/mt-pytorch/client.py

3f2fafa

Co-authored-by: Daniel J. Beutel <daniel@flower.dev>

Apply suggestions from code review

8388b23

Co-authored-by: Daniel J. Beutel <daniel@flower.dev>

Merge branch 'main' into main

3288a6a

danieljanes changed the title ~~Implement a RESTful API for Flower that supports creating and deleting nodes.~~ Support CreateNode and DeleteNode in REST API Sep 8, 2023

cnxdeveloper added 2 commits September 9, 2023 10:22

run ./dev/format.sh

bf1eec5

merge code and run format.sh

5aa634a

danieljanes requested changes Sep 10, 2023

View reviewed changes

src/py/flwr/client/rest_client/connection.py Outdated Show resolved Hide resolved

Update src/py/flwr/client/rest_client/connection.py

f92b14e

danieljanes requested changes Sep 10, 2023

View reviewed changes

src/py/flwr/client/rest_client/connection.py Outdated Show resolved Hide resolved

src/py/flwr/client/rest_client/connection.py Show resolved Hide resolved

danieljanes added 2 commits September 10, 2023 14:21

Update src/py/flwr/client/rest_client/connection.py

97f2d28

Update src/py/flwr/client/rest_client/connection.py

6732c20

cnxdeveloper and others added 2 commits September 10, 2023 22:46

run format code and modified pylint: disable -> pylint: disable-next

57de91e

Merge branch 'main' into main

2adfa7e

cnxdeveloper added 2 commits September 11, 2023 09:42

update format Markdown file

2706598

Merge branch 'main' of github.com:cnxdeveloper/flower

ca6bf3e

danieljanes requested changes Sep 11, 2023

View reviewed changes

src/py/flwr/client/rest_client/connection.py Outdated Show resolved Hide resolved

src/py/flwr/client/rest_client/connection.py Show resolved Hide resolved

danieljanes added 2 commits September 11, 2023 09:38

Update src/py/flwr/client/rest_client/connection.py

2d9509d

Update src/py/flwr/client/rest_client/connection.py

e98b1fa

danieljanes approved these changes Sep 11, 2023

View reviewed changes

danieljanes merged commit dc1730a into adap:main Sep 11, 2023
26 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support CreateNode and DeleteNode in REST API #2283

Support CreateNode and DeleteNode in REST API #2283

cnxdeveloper commented Sep 4, 2023

danieljanes commented Sep 5, 2023

cnxdeveloper commented Sep 5, 2023

danieljanes left a comment

danieljanes left a comment

danieljanes commented Sep 8, 2023

cnxdeveloper commented Sep 9, 2023

danieljanes left a comment

danieljanes commented Sep 10, 2023

danieljanes commented Sep 10, 2023

cnxdeveloper commented Sep 11, 2023 •

edited

Loading

danieljanes left a comment

Support CreateNode and DeleteNode in REST API #2283

Support CreateNode and DeleteNode in REST API #2283

Conversation

cnxdeveloper commented Sep 4, 2023

Issue

Description

Related issues/PRs

Proposal

Explanation

Checklist

Any other comments?

danieljanes commented Sep 5, 2023

cnxdeveloper commented Sep 5, 2023

danieljanes left a comment

Choose a reason for hiding this comment

danieljanes left a comment

Choose a reason for hiding this comment

danieljanes commented Sep 8, 2023

cnxdeveloper commented Sep 9, 2023

danieljanes left a comment

Choose a reason for hiding this comment

danieljanes commented Sep 10, 2023

danieljanes commented Sep 10, 2023

cnxdeveloper commented Sep 11, 2023 • edited Loading

danieljanes left a comment

Choose a reason for hiding this comment

cnxdeveloper commented Sep 11, 2023 •

edited

Loading