-
Notifications
You must be signed in to change notification settings - Fork 881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update FedProx baseline #2286
Update FedProx baseline #2286
Conversation
This line will trigger a mypy error since back in flwr=1.3 (the version pinned for SoR) |
Will update once #2301 is merged |
needs change from #2307 |
Co-authored-by: Daniel J. Beutel <daniel@flower.dev>
needs #2327 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Co-authored-by: Daniel J. Beutel <daniel@flower.dev>
After the
FedProx
baseline was added in the SoR format, some formatting checks and tests were introduced. Those were never ran againstFedProx
. This PR ensures tests pass. To achieve this:pyproject.toml
has been updated with the new content (that already is part of that in the EXTENDED_README.md in the template baseline)Once this is merged, progress can continue with #2210 and get it merged.