Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Flower Datasets tests as GitHub workflow #2345

Merged
merged 21 commits into from
Sep 20, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
da40bdb
Add datasets tests as GitHub workflow
adam-narozniak Sep 12, 2023
887ebd0
Merge branch 'main' into add-datasets-ci-tests
tanertopal Sep 13, 2023
bb93246
Update .github/workflows/datasets.yml
tanertopal Sep 13, 2023
7f1abb7
Update .github/workflows/datasets.yml
tanertopal Sep 13, 2023
0613063
Update .github/workflows/datasets.yml
tanertopal Sep 13, 2023
f0f4f20
Update .github/workflows/datasets.yml
tanertopal Sep 13, 2023
258327a
Update .github/workflows/datasets.yml
tanertopal Sep 13, 2023
bcba8f9
Make flwr_tool.init_py_check discoverable
adam-narozniak Sep 14, 2023
61ec33b
Merge remote-tracking branch 'origin/add-datasets-ci-tests' into add-…
adam-narozniak Sep 14, 2023
ede672d
Make flwr_tool.init_py_check discoverable
adam-narozniak Sep 14, 2023
8043041
Check the pwd, path, pythonpath
adam-narozniak Sep 14, 2023
5d9d912
Make flwr_tool.init_py_check discoverable
adam-narozniak Sep 14, 2023
205ba93
Make flwr_tool.init_py_check discoverable
adam-narozniak Sep 14, 2023
ee5e456
Print out paths
adam-narozniak Sep 15, 2023
df9dff8
Print out paths
adam-narozniak Sep 15, 2023
a668ea1
Remove path export
adam-narozniak Sep 15, 2023
e11bf89
Clear up test.sh
adam-narozniak Sep 15, 2023
9cc92e1
Merge branch 'main' into add-datasets-ci-tests
tanertopal Sep 15, 2023
7a09cc3
Update .github/workflows/datasets.yml
tanertopal Sep 20, 2023
56c6a3b
Merge branch 'main' into add-datasets-ci-tests
tanertopal Sep 20, 2023
59a7b3e
Merge branch 'main' into add-datasets-ci-tests
tanertopal Sep 20, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions .github/workflows/datasets.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
name: Datasets

on:
push:
branches:
- main
pull_request:
branches:
- main

concurrency:
group: ${{ github.workflow }}-${{ github.ref == 'refs/heads/main' && github.run_id || github.event.pull_request.number || github.ref }}
cancel-in-progress: true

tanertopal marked this conversation as resolved.
Show resolved Hide resolved
defaults:
run:
working-directory: datasets

jobs:
test_core:
runs-on: ubuntu-22.04
strategy:
matrix:
# Latest version which comes cached in the host image can be found here:
# https://github.com/actions/runner-images/blob/main/images/linux/Ubuntu2204-Readme.md#python
# In case of a mismatch, the job has to download Python to install it.
# Note: Due to a bug in actions/setup-python we have to put 3.10 in
# qoutes as it will otherwise will assume 3.1
python: [3.8, 3.9, '3.10']

name: Python ${{ matrix.python }}

steps:
- uses: actions/checkout@v4
- name: Bootstrap
uses: ./.github/actions/bootstrap
with:
python-version: ${{ matrix.python }}
- name: Install dependencies (mandatory only)
run: python -m poetry install --all-extras
- name: Test (formatting + unit tests)
run: ./dev/test.sh
4 changes: 4 additions & 0 deletions datasets/dev/test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@
set -e
cd "$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )"/../

# Append path to PYTHONPATH that makes flwr_tool.init_py_check discoverable
PARENT_DIR=$(dirname "$(pwd)") # Go one dir up from flower/datasets
export PYTHONPATH="${PYTHONPATH}:${PARENT_DIR}/src/py"

echo "=== test.sh ==="

echo "- Start Python checks"
Expand Down