Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change workload_id type to uint64 #2413

Merged
merged 10 commits into from
Oct 7, 2023
Merged

Change workload_id type to uint64 #2413

merged 10 commits into from
Oct 7, 2023

Conversation

panh99
Copy link
Contributor

@panh99 panh99 commented Sep 22, 2023

Changed data type and corresponding unit tests.

danieljanes
danieljanes approved these changes Oct 7, 2023
View reviewed changes
Copy link
Member

@danieljanes danieljanes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! 🙌

@danieljanes danieljanes merged commit e7977b5 into main Oct 7, 2023
26 checks passed
@danieljanes danieljanes deleted the id-type-change branch October 7, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlesbvll charlesbvll charlesbvll approved these changes

@danieljanes danieljanes danieljanes approved these changes

@tanertopal tanertopal Awaiting requested review from tanertopal tanertopal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@panh99 @danieljanes @charlesbvll @tanertopal