Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gRPC-rere support for the C++ SDK #2537

Merged
merged 8 commits into from
Oct 30, 2023
Merged

Add gRPC-rere support for the C++ SDK #2537

merged 8 commits into from
Oct 30, 2023

Conversation

charlesbvll
Copy link
Member

@charlesbvll charlesbvll commented Oct 26, 2023

Issue

Description

The current C++ SDK does not support gRPC-rere, which means it won't be able to be compatible with future features of Flower.

Related issues/PRs

N/A

Proposal

Explanation

This PR implements a new gRPC-rere compatible start_rere_client function in the C++ SDK and adds it to the quickstart-cpp example.

Checklist

  • Implement proposed change
  • Update changelog
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Any other comments?

Tests will be implemented in another PR, as we also need to add tests for the other files.

@charlesbvll charlesbvll marked this pull request as ready for review October 26, 2023 17:33
@tanertopal tanertopal enabled auto-merge (squash) October 30, 2023 08:08
Copy link
Member

@tanertopal tanertopal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@tanertopal tanertopal merged commit ffcca20 into main Oct 30, 2023
27 checks passed
@tanertopal tanertopal deleted the add-cpp-grpc-rere branch October 30, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants