Deprecate NumPyClient
#2563
Merged
Deprecate NumPyClient
#2563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jafermarq
added
documentation
danieljanes
reviewed
Jan 31, 2024
Comment on lines
14094
to
14095
| ":code:`NumPyClient` and call :code:`fl.client.start_client()` or " | ||
| ":code:`fl.client.start_numpy_client()`. The string " | ||
| ":code:`fl.client.start_client()`. The string " |
danieljanes
reviewed
Jan 31, 2024
danieljanes
reviewed
Jan 31, 2024
danieljanes
reviewed
Jan 31, 2024
|
LGTM! |
danieljanes
approved these changes
Feb 1, 2024
danieljanes
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts #2561.
TODOs:
NumPyClientandstart_numpy_clientis deprecated.MXNetexamples #2724MXNete2e test #2870.pofiles for translations.to_client()-> Make examples usestart_client(). #2718start_numpy_client()from e2e tests -> Stop usingstart_numpy_clientin e2e tests #2869