Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XGBoost Flower simulation #2668

Merged
merged 39 commits into from
Feb 1, 2024
Merged

XGBoost Flower simulation #2668

merged 39 commits into from
Feb 1, 2024

Conversation

yan-gao-GY
Copy link
Contributor

Issue

Description

Using Flower simulation is an easy way to simulate large-scale XGBoost experiments. However, the current XGBoost implementation does not support this.

Related issues/PRs

This PR is created on the top of this PR (non-stateful client).

Proposal

  • We create sim.py to do Flower simulation.
  • Some shared functions are removed to utils.py.
  • Create a new arguments parser for simulation in utils.py.
  • Update readme with new experimental results for bagging and cyclic training.
  • Add more explanation in readme.

danieljanes
danieljanes previously approved these changes Dec 7, 2023
@danieljanes danieljanes enabled auto-merge (squash) December 7, 2023 12:48
@jafermarq jafermarq marked this pull request as draft December 7, 2023 12:52
@jafermarq jafermarq marked this pull request as ready for review January 23, 2024 16:48
jafermarq
jafermarq previously approved these changes Jan 23, 2024
@jafermarq jafermarq enabled auto-merge (squash) January 23, 2024 16:49
@jafermarq jafermarq merged commit 0f3a734 into main Feb 1, 2024
27 checks passed
@jafermarq jafermarq deleted the xgb-flwr-sim-comprehensive branch February 1, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants