Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add E2E test for WorkloadState and NodeState #2696

Merged
merged 4 commits into from
Dec 8, 2023

Conversation

jafermarq
Copy link
Contributor

The E2E test is designed as follows:

  • Clients append to their state the current timestamp the moment they do fit() and evaluate(). This results in the client's state to have a collection of monotonically increasing timestamps.
  • The server communicates to the client their timestamps series through the metrics return argument
  • The strategy checks for timestamp monotonicity after aggregation.

If test pass it means that the mechanism of injecting the WorkloadState into the client objects after being retrieved from the NodeState is working.

danieljanes
danieljanes previously approved these changes Dec 8, 2023
@jafermarq jafermarq marked this pull request as ready for review December 8, 2023 13:47
@danieljanes danieljanes merged commit dbf56d9 into main Dec 8, 2023
27 checks passed
@danieljanes danieljanes deleted the e2e-test-nodestate-workloadstate branch December 8, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants