Fix build of docker base image #2705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robert-Steiner
changed the title
|
My bad. I should have caught this in the review. We had that issue in the past, and I had forgotten it. |
Don't worry, I should have tested it to make sure it works |
Robert-Steiner
force-pushed
the
fix-docker-base-build
branch
from
d0882ae
to
2e15903
Compare
|
ci passed this time: https://github.com/adap/flower/actions/runs/7169819131 |
Robert-Steiner
requested review from
danieljanes and
tanertopal
as code owners
|
Still need to double check this pr. something seems off with the tags |
Robert-Steiner
force-pushed
the
fix-docker-base-build
branch
6 times, most recently
from
473024b
to
2933ee7
Compare
Robert-Steiner
force-pushed
the
fix-docker-base-build
branch
from
2933ee7
to
be28607
Compare
|
there was another small error that i had fix. if job upload an artifact with the same name, they will override each other. |
tanertopal
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The values (python versions) in the matrix were interpreted as floats. When the value
3.10was passed to the build argumentPYTHON_VERSIONthe zero was cut off. This lead the docker build command to fail because it tried to install python3.1.Description
fail-fasttofalse. if one build fails, we still can push the other.Related issues/PRs
Proposal
Explanation
Checklist
#contributions)Any other comments?