Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix version of Jax to solve Poetry resolve issue #2709

Merged
merged 2 commits into from
Dec 17, 2023
Merged

Fix version of Jax to solve Poetry resolve issue #2709

merged 2 commits into from
Dec 17, 2023

Conversation

charlesbvll
Copy link
Member

@charlesbvll charlesbvll commented Dec 15, 2023 •
edited
Loading

Issue

Description

Currently Poetry breaks the Jax E2E CI by taking too much time to resolve it.

Related issues/PRs

N/A

Proposal

Explanation

Fix Jax to a specific version to make Poetry faster.

Checklist

  • Implement proposed change
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Any other comments?

N/A

@charlesbvll charlesbvll marked this pull request as ready for review December 15, 2023 12:56
@jafermarq jafermarq enabled auto-merge (squash) December 15, 2023 16:45
@jafermarq jafermarq merged commit 06d08d5 into main Dec 17, 2023
27 checks passed
@jafermarq jafermarq deleted the fix-jax-version branch December 17, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jafermarq jafermarq jafermarq approved these changes

@tanertopal tanertopal tanertopal approved these changes

@danieljanes danieljanes Awaiting requested review from danieljanes danieljanes is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@charlesbvll @tanertopal @jafermarq