Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make node-id required for quickstart-pytorch #2712

Merged
merged 10 commits into from
Dec 20, 2023
Merged

Make node-id required for quickstart-pytorch #2712

merged 10 commits into from
Dec 20, 2023

Conversation

neogismm
Copy link
Contributor

@neogismm neogismm commented Dec 15, 2023 •
edited
Loading

Issue

Description

Related issues/PRs

Related to issue #2711

Proposal

Explanation

Checklist

  • Implement proposed change
  • Write tests
  • Update documentation
  • Update changelog
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Any other comments?

jafermarq
jafermarq reviewed Dec 15, 2023
View reviewed changes
Copy link
Contributor

@jafermarq jafermarq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @neogismm,

Thanks for opening the PR. I added a small comment. I think the best is to edit the argparse and make the node-id to be "required"

examples/quickstart-pytorch/client.py Outdated Show resolved Hide resolved
examples/quickstart-pytorch/run.sh Outdated Show resolved Hide resolved
examples/quickstart-pytorch/client.py Show resolved Hide resolved
@jafermarq jafermarq changed the title [quickstart-pytorch] node-id is now a required positional argument running client.py Make node-id required for quickstart-pytorch Dec 15, 2023
jafermarq
jafermarq approved these changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@jafermarq jafermarq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neogismm ,

Many thanks for the PR! 🙌

@jafermarq jafermarq enabled auto-merge (squash) December 15, 2023 16:24
@neogismm
Copy link
Contributor Author

Hi @neogismm,

Thanks for opening the PR. I added a small comment. I think the best is to edit the argparse and make the node-id to be "required"

I found that removing "--" before an arg makes it a required arg. Nonetheless, your solution does the same thing.
Thanks for the opportunity @jafermarq 🙌

@jafermarq jafermarq merged commit 1bf2ac3 into adap:main Dec 20, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jafermarq jafermarq jafermarq approved these changes

@danieljanes danieljanes Awaiting requested review from danieljanes danieljanes is a code owner

@tanertopal tanertopal Awaiting requested review from tanertopal tanertopal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@neogismm @jafermarq @tanertopal @flwrmachine