Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependabot pr ci #2745

Merged
merged 2 commits into from
Dec 22, 2023
Merged

Fix dependabot pr ci #2745

merged 2 commits into from
Dec 22, 2023

Conversation

Robert-Steiner
Copy link
Member

@Robert-Steiner Robert-Steiner commented Dec 21, 2023

Issue

in #2732 we skipped the upload step if the actor is dependabot. However, the uploaded artifacts are required for the following jobs. We revert #2732 and allow dependabot upload/downloading the artifacts. We forgot to do the same for the install flwr wheel from artifact store step. The CI will still work because flwr is installed in the previous step.

Description

Related issues/PRs

Proposal

Explanation

Checklist

  • Implement proposed change
  • Write tests
  • Update documentation
  • Update changelog
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Any other comments?

@Robert-Steiner
Copy link
Member Author

Moved back to draft because @charlesbvll has a good idea to solve the problem without secrets.

@Robert-Steiner Robert-Steiner marked this pull request as ready for review December 21, 2023 13:18
Copy link
Member

@charlesbvll charlesbvll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tanertopal tanertopal enabled auto-merge (squash) December 22, 2023 08:15
@tanertopal tanertopal merged commit 48ed784 into main Dec 22, 2023
27 checks passed
@tanertopal tanertopal deleted the fix-dependabot-action branch December 22, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants