Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when using SQLite with gRPC-rere #2874

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Conversation

charlesbvll
Copy link
Member

Issue

Description

When starting a flower-server with SQLite, we get an error saying that SQLite objects created in a specific thread can only be used in that thread.

Related issues/PRs

N/A

Proposal

Explanation

The issue is caused by the fact that we pass the same SQLite State object to all the FleetServicer functions that are called on different threads. Instead, we should create the State object in each of the FleetServicer functions.

Checklist

  • Implement proposed change
  • Update the changelog entry below
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Changelog entry

Any other comments?

Should this be an extensive changelog entry?

@danieljanes danieljanes merged commit 44101fe into main Jan 31, 2024
27 checks passed
@danieljanes danieljanes deleted the fix-sqlite-error branch January 31, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants