Fix error when using SQLite with gRPC-rere #2874
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Description
When starting a
flower-server
with SQLite, we get an error saying that SQLite objects created in a specific thread can only be used in that thread.Related issues/PRs
N/A
Proposal
Explanation
The issue is caused by the fact that we pass the same SQLite
State
object to all theFleetServicer
functions that are called on different threads. Instead, we should create theState
object in each of theFleetServicer
functions.Checklist
#contributions
)Changelog entry
Any other comments?
Should this be an extensive changelog entry?