Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLI to Flower #2942

Merged
merged 46 commits into from
Feb 20, 2024
Merged

Add CLI to Flower #2942

merged 46 commits into from
Feb 20, 2024

Conversation

tanertopal
Copy link
Member

Issue

Description

Related issues/PRs

Proposal

Explanation

Checklist

  • Implement proposed change
  • Write tests
  • Update documentation
  • Update the changelog entry below
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Changelog entry

Any other comments?

@tanertopal tanertopal marked this pull request as ready for review February 14, 2024 15:32
@danieljanes danieljanes marked this pull request as draft February 15, 2024 21:59
@danieljanes
Copy link
Member

@tanertopal converted to draft b/c of merge conflicts

pyproject.toml Outdated Show resolved Hide resolved
@tanertopal tanertopal marked this pull request as ready for review February 15, 2024 23:51
@tanertopal
Copy link
Member Author

@danieljanes The conflict is resolved.

src/py/flwr/cli/__init__.py Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
src/py/flwr/cli/app.py Outdated Show resolved Hide resolved
src/py/flwr/cli/app.py Outdated Show resolved Hide resolved
src/py/flwr/cli/new/new.py Outdated Show resolved Hide resolved
src/py/flwr/cli/new/templates/README.md.tpl Outdated Show resolved Hide resolved
src/py/flwr/cli/new/templates/README.md.tpl Outdated Show resolved Hide resolved
src/py/flwr/cli/new/templates/README.md.tpl Outdated Show resolved Hide resolved
src/py/flwr/cli/new/templates/README.md.tpl Outdated Show resolved Hide resolved
src/py/flwr/cli/new/templates/main.pytorch.py.tpl Outdated Show resolved Hide resolved
tanertopal and others added 15 commits February 18, 2024 18:59
Co-authored-by: Daniel J. Beutel <daniel@flower.ai>
Co-authored-by: Daniel J. Beutel <daniel@flower.ai>
Co-authored-by: Daniel J. Beutel <daniel@flower.ai>
Co-authored-by: Daniel J. Beutel <daniel@flower.ai>
Co-authored-by: Daniel J. Beutel <daniel@flower.ai>
Co-authored-by: Daniel J. Beutel <daniel@flower.ai>
Co-authored-by: Daniel J. Beutel <daniel@flower.ai>
Co-authored-by: Daniel J. Beutel <daniel@flower.ai>
Co-authored-by: Daniel J. Beutel <daniel@flower.ai>
Co-authored-by: Daniel J. Beutel <daniel@flower.ai>
Co-authored-by: Daniel J. Beutel <daniel@flower.ai>
src/py/flwr/cli/new/new.py Outdated Show resolved Hide resolved
src/py/flwr/cli/new/templates/flower.toml.tpl Outdated Show resolved Hide resolved
src/py/flwr/cli/new/templates/README.md.tpl Outdated Show resolved Hide resolved
src/py/flwr/cli/new/templates/README.md.tpl Outdated Show resolved Hide resolved
@@ -0,0 +1 @@
"""$project_name: A Flower / PyTorch app."""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the text!

Instead of main.py, we need server.py and client.py. Or we add both ServerApp and ClientApp to main.py.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll make the adjustment.

src/py/flwr/cli/new/templates/README.md.tpl Outdated Show resolved Hide resolved
tanertopal and others added 6 commits February 20, 2024 09:58
Co-authored-by: Daniel J. Beutel <daniel@flower.ai>
Co-authored-by: Daniel J. Beutel <daniel@flower.ai>
Co-authored-by: Daniel J. Beutel <daniel@flower.ai>
Co-authored-by: Daniel J. Beutel <daniel@flower.ai>
@danieljanes danieljanes enabled auto-merge (squash) February 20, 2024 11:16
@danieljanes danieljanes merged commit 538908b into main Feb 20, 2024
28 checks passed
@danieljanes danieljanes deleted the flower_cli branch February 20, 2024 11:25
tanertopal added a commit that referenced this pull request Feb 20, 2024
…ate_docformatter

* 'update_docformatter' of github.com:adap/flower:
  Fix small typos (#2986)
  Update models.py (#2985)
  Move `*Record` and `RecordSet` to `record` package (#2984)
  Improve `*Record` (#2982)
  Introduce central DP (server-side fixed clipping) (#2798)
  Apply suggestions from code review
  pin virtualenv version to 20.21.0 in baselines (#2981)
  Add `flwr` CLI (#2942)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants