Add client auth E2E test #2979
Merged
Add client auth E2E test #2979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieljanes
reviewed
Apr 29, 2024
danieljanes
reviewed
Apr 29, 2024
…' into add-client-auth-e2e
danieljanes
reviewed
Apr 29, 2024
danieljanes
reviewed
Apr 29, 2024
Co-authored-by: Daniel J. Beutel <daniel@flower.ai>
Co-authored-by: Daniel J. Beutel <daniel@flower.ai>
Co-authored-by: Daniel J. Beutel <daniel@flower.ai>
danieljanes
approved these changes
Apr 29, 2024
mohammadnaseri
pushed a commit
that referenced
this pull request
May 2, 2024
Co-authored-by: jafermarq <javier@flower.ai> Co-authored-by: Daniel J. Beutel <daniel@flower.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Description
There is no e2e test for client authentication feature that can make sure client authentication works end-to-end from user perspective.
Related issues/PRs
Proposal
Explanation
Add e2e test using pytorch framework.
Checklist
#contributions)Changelog entry
Any other comments?