Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flower-client-authentication code example #2999

Merged
merged 23 commits into from
May 3, 2024
Merged

Conversation

danielnugraha
Copy link
Contributor

Issue

Description

There is no code example to showcase client authentication in Flower.

Related issues/PRs

Proposal

Explanation

Add flower-client-authentication code example using app-pytorch as the underlying FL routine. Merge only after the client authentication PRs have been merged.

Checklist

  • Implement proposed change
  • Write tests
  • Update documentation
  • Update the changelog entry below
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Changelog entry

Any other comments?

danielnugraha and others added 11 commits May 3, 2024 07:09
Co-authored-by: Daniel J. Beutel <daniel@flower.ai>
Co-authored-by: Daniel J. Beutel <daniel@flower.ai>
Co-authored-by: Daniel J. Beutel <daniel@flower.ai>
Co-authored-by: Daniel J. Beutel <daniel@flower.ai>
Co-authored-by: Daniel J. Beutel <daniel@flower.ai>
Co-authored-by: Daniel J. Beutel <daniel@flower.ai>
Co-authored-by: Daniel J. Beutel <daniel@flower.ai>
Copy link
Contributor

@chongshenng chongshenng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the PR @danielnugraha. Some minor formatting to be done, but otherwise, it looks good!

examples/flower-client-authentication/README.md Outdated Show resolved Hide resolved
examples/flower-client-authentication/README.md Outdated Show resolved Hide resolved
examples/flower-client-authentication/README.md Outdated Show resolved Hide resolved
examples/flower-client-authentication/README.md Outdated Show resolved Hide resolved
examples/flower-client-authentication/README.md Outdated Show resolved Hide resolved
examples/flower-client-authentication/README.md Outdated Show resolved Hide resolved
examples/flower-client-authentication/server.py Outdated Show resolved Hide resolved
@danieljanes danieljanes enabled auto-merge (squash) May 3, 2024 19:21
@danieljanes danieljanes dismissed chongshenng’s stale review May 3, 2024 19:33

Requested changes were implemented

@danieljanes danieljanes merged commit 6242c95 into main May 3, 2024
28 checks passed
@danieljanes danieljanes deleted the add-code-example branch May 3, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants