Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add terminate method to backends and introduce asyncio stopping event. #3008

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Add terminate method to backends and introduce asyncio stopping event. #3008

merged 1 commit into from
Feb 26, 2024

Conversation

jafermarq
Copy link
Contributor

Introducing some components to gracefully terminate a simulation:

  • terminate() method for Backends. In the case of the RayBackend it will manually terminate each actor
  • Pass a asyncio.Event to the entry function that starts the simulation. This will be used to terminate tasks when the event is (externally) set.

@jafermarq jafermarq added the simulation An issue related to Flower's simulation label Feb 25, 2024
@jafermarq jafermarq mentioned this pull request Feb 25, 2024
Merged
@danieljanes danieljanes merged commit 2b0c33f into main Feb 26, 2024
28 checks passed
@danieljanes danieljanes deleted the vce-fleet-terminate-and-rename branch February 26, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieljanes danieljanes danieljanes approved these changes

@tanertopal tanertopal Awaiting requested review from tanertopal tanertopal is a code owner

Assignees
No one assigned
Labels
simulation An issue related to Flower's simulation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jafermarq @danieljanes