-
Notifications
You must be signed in to change notification settings - Fork 881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make flower-simulation
accept ClientApp
and ServerApp
objects
#3024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Daniel J. Beutel <daniel@flower.ai>
danieljanes
reviewed
Mar 2, 2024
danieljanes
reviewed
Mar 2, 2024
danieljanes
reviewed
Mar 5, 2024
danieljanes
reviewed
Mar 5, 2024
danieljanes
reviewed
Mar 5, 2024
danieljanes
reviewed
Mar 5, 2024
danieljanes
reviewed
Mar 5, 2024
danieljanes
reviewed
Mar 5, 2024
danieljanes
reviewed
Mar 5, 2024
danieljanes
reviewed
Mar 5, 2024
danieljanes
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables running the new Simulation Engine on Notebooks. For this to be possible we need:
run_simulation
so it acceptsClientApp
andServerApp
objects and not just strings pointing to modules where those are defined.ServerApp
). This is needed since notebooks have their ownAsyncio
event loop running, conflicting with some parts of the Simulation Engine if they run on the main thread. Running on the main thread remains the default behaviour when the code is executed outside a notebook environment (whether it is from the cli viaflower-simulation
or from a python script)