Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn once if TTL is set #3195

Merged
merged 4 commits into from
Apr 2, 2024
Merged

Warn once if TTL is set #3195

merged 4 commits into from
Apr 2, 2024

Conversation

jafermarq
Copy link
Contributor

  • Warns once if TTL is set in create_message() or create_reply.
  • create_message now accepts optional ttl (mirroring create_reply signature and logic to set DEFAULT_TTL).

jafermarq and others added 3 commits April 2, 2024 14:46
@jafermarq jafermarq marked this pull request as ready for review April 2, 2024 14:12
@danieljanes danieljanes merged commit 084835a into main Apr 2, 2024
28 checks passed
@danieljanes danieljanes deleted the warn-ttl-not-enforced branch April 2, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieljanes danieljanes danieljanes approved these changes

@tanertopal tanertopal Awaiting requested review from tanertopal tanertopal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jafermarq @danieljanes