Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use abstract Driver #3281

Merged
merged 25 commits into from
Apr 22, 2024
Merged

Use abstract Driver #3281

merged 25 commits into from
Apr 22, 2024

Conversation

jafermarq
Copy link
Contributor

@jafermarq jafermarq commented Apr 17, 2024 •
edited
Loading

This PR:

  • Renames the original Driver class to GrpcDriver and makes it derive from the abstract Driver
  • The content of the abstract Driver is in driver.py
  • The content of the original driver (now GrpcDriver) is now in grpc_driver.py
  • Previous instantiation of Driver is now replaced with GrpcDriver

@jafermarq jafermarq mentioned this pull request Apr 17, 2024
Merged
@jafermarq
Copy link
Contributor Author

jafermarq commented Apr 17, 2024 •
edited
Loading

Should we shorten the docstrings for GrpcDriver? since they are very much based on what the base Driver already contains...

Base automatically changed from fuse-driver-driverhelper to main April 20, 2024 11:25
@danieljanes
Copy link
Member

Should we shorten the docstrings for GrpcDriver? since they are very much based on what the base Driver already contains...

Yes, that'd be good. The only docstrings users should refer to / be exposed to are the ones in the abstract Driver class.

@jafermarq jafermarq marked this pull request as ready for review April 22, 2024 14:25
@danieljanes danieljanes enabled auto-merge (squash) April 22, 2024 17:08
@danieljanes danieljanes merged commit d22be5c into main Apr 22, 2024
27 checks passed
@danieljanes danieljanes deleted the driver-based-on-abstract branch April 22, 2024 17:10
mohammadnaseri pushed a commit that referenced this pull request May 2, 2024
@jafermarq @mohammadnaseri
Use abstract Driver (#3281)
0eb9ec6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieljanes danieljanes danieljanes approved these changes

@tanertopal tanertopal Awaiting requested review from tanertopal tanertopal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jafermarq @danieljanes