Verify node_id in client auth
#3308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erceptor' into add-client-auth-interceptor
danieljanes
requested changes
Apr 30, 2024
Added. |
danieljanes
reviewed
May 6, 2024
|
|
||
| # Handle RPC here instead of passing to default method_handler | ||
| if node_id is not None: | ||
| # State has lock already this execution is serialized |
There was a problem hiding this comment.
This comment isn't true any more
danieljanes
reviewed
May 6, 2024
danieljanes
reviewed
May 6, 2024
danieljanes
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Description
There is no verification of the assigned
node_idfor a particularpublic_key, and assignednode_idcan't be reused after a client dies.Related issues/PRs
Proposal
Explanation
node_idin messages sent.node_id.Checklist
#contributions)Changelog entry
Any other comments?